Pr/7794 Redux -- Core 4.9 / Custom CSS by georgestephanis · Pull Request #8028 · Automattic/jetpack

georgestephanis · 2017-10-20T19:07:53Z

Minimum revision of core to test against: https://core.trac.wordpress.org/changeset/41992

Adding it in twice is bad -- the first time shouldn't need it? May need to evaluate dependencies for what Core ships and bundles though for less/sass.

This uses specificity to match Core styles and adjusts the height to accomodate core style changes.

We need to maintain an old version of the file for pre-4.9 versions of WordPress as we support vCurr and vCurr - 1.

This should help clear out the cruft. Let's start over and rearchitect the file.

We need this to be `jetpackCss`

We don't really need to override it any longer, I don't think.

georgestephanis · 2017-10-23T20:50:28Z

This PR is dependent on https://core.trac.wordpress.org/changeset/41974 being in your core checkout. If something's screwy, try a svn up first.

georgestephanis · 2017-10-23T21:56:48Z

Please test this for functionality and behavior, as well as regressions.

…data model.

georgestephanis · 2017-10-24T15:07:51Z

Vizrec:

Old version in core 4.8.2:

New version in Core 4.9-beta?

I had to adjust the editor height down a bit, which shrunk the old one a bit too, but that's small potatoes and only for folks running older versions of core.

Otherwise the gutter may not get the errors displayed in it.

@westonruter

Props @westonruter

As of https://core.trac.wordpress.org/changeset/41992

Simpler to read code yields better maintainability.

georgestephanis · 2017-10-24T16:42:04Z

If testing this, make sure you're up to https://core.trac.wordpress.org/changeset/41992 on your core checkout.

zinigor · 2017-10-24T17:02:10Z

Tested with Core both before 41992 and after, everything seems to be working correctly. There's one minor problem that I have noticed. If you follow these steps:

start with a blank CSS;
type up a valid CSS modification with SASS (or LESS) that's not backwards CSS compatible, like a { &:hover{ color: red; } };
abandon customizing;
return to the customizer and restore the revision;
see the errors that only disappear after you toggle the preprocessor.

georgestephanis · 2017-10-24T17:10:48Z

To clarify, the errors only display when the mode is set to CSS right? That's expected as it's invalid css.

georgestephanis · 2017-10-24T17:11:38Z

Or do you mean that the css persists but preprocessor selection doesn't? @zinigor

zinigor · 2017-10-24T17:28:31Z

Yes, sorry, I meant that the selector persists, but the errors still get displayed as though it's set to be simple CSS.

georgestephanis · 2017-10-24T19:14:57Z

Got the design review from @MichaelArestad yesterday, clearing the tag.

zinigor

Disregard my latest comment - I can no longer reproduce the problem, plus it was really minor, should not be a problem to anyone.

westonruter and others added 3 commits September 16, 2017 14:45

Add initial Jetpack CSS support for Code Editor control in core patch

48d98c8

Comments detailing conditionals.

b898403

We're conditionally adding this in the subsequent line.

3be90b1

Adding it in twice is bad -- the first time shouldn't need it? May need to evaluate dependencies for what Core ships and bundles though for less/sass.

georgestephanis self-assigned this Oct 20, 2017

georgestephanis added the [Feature] Custom CSS label Oct 20, 2017

georgestephanis added 9 commits October 20, 2017 15:57

Adjust CSS to handle height assignment.

06076d4

This uses specificity to match Core styles and adjusts the height to accomodate core style changes.

Remove unused return value variable.

c3c4c51

Roughing in new 4.9 version of the file.

5505240

We need to maintain an old version of the file for pre-4.9 versions of WordPress as we support vCurr and vCurr - 1.

Tidy and purge. Strip it down and then build it back up.

64ce733

This should help clear out the cruft. Let's start over and rearchitect the file.

Errr, they're already jQuery objects by the documentation.

70da021

Whitespace

46a3670

Override the type from get_object_vars()

42f853a

We need this to be `jetpackCss`

Simplify. Initialize the core control to the right code format.

3aeb603

We don't really need to override it any longer, I don't think.

Get the mode switching in place.

d004d95

oskosk mentioned this pull request Oct 23, 2017

[WIP] Add Jetpack CSS support for Code Editor control in core patch #7794

Closed

georgestephanis added 3 commits October 23, 2017 14:41

Revert legacy file as we're working in new one.

b7b9432

Run addLabels at document ready.

19f7e6b

Minor reorg.

fe74440

georgestephanis added 4 commits October 23, 2017 16:50

Whitespace tidy

511b2e5

Create the div for the css links to go into.

e0bad79

Whitespace tidying

e7873a2

tabs > spaces

52fb1ba

georgestephanis added [Pri] BLOCKER [Status] Needs Design Review Design has been added. Needs a review! [Status] Needs Review This PR is ready for review. labels Oct 23, 2017

georgestephanis added this to the 5.5 milestone Oct 23, 2017

georgestephanis added 2 commits October 24, 2017 10:36

Switch from watching the html dropdown to listening to events on the …

1cfb5e6

…data model.

Quote reserved word.

2359dee

CSS Tweaks for 4.9

c846c04

georgestephanis added 6 commits October 24, 2017 12:14

Activate linting after adding the gutters back in.

6fae43e

Otherwise the gutter may not get the errors displayed in it.

Don't assume there are no other gutters.

cb7d3e8

Props @westonruter

Remove the wp alias and clarify the wp.customize alias.

ac08aeb

Simplify and remove addDesc method.

f45ac94

Remove toggling of the Gutters, Core handles this now.

cb95dcc

As of https://core.trac.wordpress.org/changeset/41992

Remove addTitle function and inline it.

693e58d

Simpler to read code yields better maintainability.

georgestephanis removed the [Status] Needs Design Review Design has been added. Needs a review! label Oct 24, 2017

zinigor approved these changes Oct 24, 2017

View reviewed changes

zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Oct 24, 2017

oskosk approved these changes Oct 25, 2017

View reviewed changes

oskosk merged commit 84e9054 into master Oct 25, 2017

oskosk deleted the pr/7794 branch October 25, 2017 13:59

oskosk removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 25, 2017

georgestephanis mentioned this pull request Oct 25, 2017

Custom CSS: Re-use CodeMirror bundled in Core and the new code editor API #7776

Closed

jeherve added [Status] Needs Changelog [Status] Needs Testing We need to add this change to the testing call for this month's release and removed [Status] Needs Changelog [Status] Needs Testing We need to add this change to the testing call for this month's release labels Oct 26, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Pr/7794 Redux -- Core 4.9 / Custom CSS#8028

Pr/7794 Redux -- Core 4.9 / Custom CSS#8028
oskosk merged 28 commits into
masterfrom
pr/7794

georgestephanis commented Oct 20, 2017 •

edited

Loading

Uh oh!

georgestephanis commented Oct 23, 2017

Uh oh!

georgestephanis commented Oct 23, 2017

Uh oh!

georgestephanis commented Oct 24, 2017

Uh oh!

georgestephanis commented Oct 24, 2017

Uh oh!

zinigor commented Oct 24, 2017

Uh oh!

georgestephanis commented Oct 24, 2017

Uh oh!

georgestephanis commented Oct 24, 2017

Uh oh!

zinigor commented Oct 24, 2017

Uh oh!

georgestephanis commented Oct 24, 2017

Uh oh!

zinigor left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

georgestephanis commented Oct 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

georgestephanis commented Oct 23, 2017

Uh oh!

georgestephanis commented Oct 23, 2017

Uh oh!

georgestephanis commented Oct 24, 2017

Uh oh!

georgestephanis commented Oct 24, 2017

Uh oh!

zinigor commented Oct 24, 2017

Uh oh!

georgestephanis commented Oct 24, 2017

Uh oh!

georgestephanis commented Oct 24, 2017

Uh oh!

zinigor commented Oct 24, 2017

Uh oh!

georgestephanis commented Oct 24, 2017

Uh oh!

zinigor left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

georgestephanis commented Oct 20, 2017 •

edited

Loading