Simple payments: fix success message styling#7528
Merged
lamosty merged 1 commit intofeature/simple-paymentsfrom Jul 25, 2017
Merged
Simple payments: fix success message styling#7528lamosty merged 1 commit intofeature/simple-paymentsfrom
lamosty merged 1 commit intofeature/simple-paymentsfrom
Conversation
jhnstn
reviewed
Jul 25, 2017
Member
There was a problem hiding this comment.
Nice. I like this better than assigning the message to a variable.
jhnstn
reviewed
Jul 25, 2017
Member
There was a problem hiding this comment.
Good catch, I thought we already had jQuery marked as a dependency
Contributor
Author
There was a problem hiding this comment.
Yeah. But this change is not about jQuery. :) It's about adding self::$version so we bust cache.
Member
There was a problem hiding this comment.
derp, didn't see the linewidth overflow.
Member
|
Test flow works form me. |
Fixes styling of success messages.
8f11cc0 to
0daf5bd
Compare
eliorivero
pushed a commit
that referenced
this pull request
Jul 25, 2017
* Introduce Jetpack_Simple_Payments class, load it * Add doc about format to CPT * Add more docs * Add enabled / disabled status * Add shortcode * reg shortcode * Add shortcode logic * Fix func * fix class * rename to product * Better content passing * Pass proper JS * Add comments * Rename to "paypal-express-checkout" * Add price * Label change * jshint fixes * filter * items * Throw error if paypal not defined * Info about script hosted with PP * Get rid of static keyword * Fix some lint issues * proper header * Adjust classes to WP coding standards * Change header * Change comment * add payload for number of items * Make ids work for paypal code * repair init code * Introduce ID for form * Add endpoint urls * Better domain * Endpoint urls with blog_id * Fix id * Add version * Change endpoint * Make sandbox * Add post meta syncing * Sandbox management * Review fixes * remove console Attempt to make test pass in JS * Fir for missing product * simple-payments: print message when the transaction ends. * simple-payments: clean message placeholder * simple-payments: implement styles to the block * some change * simple-payments: improve showing transaction messages * Put the purchase message into HTML, hidden by default * Toggle purchase messages with either success/error and message * Use p tag instead of div with margin Props @iamtakashi for the suggestion. * Remove unneeded code * Fix typo * Fix paypal checkout.js script error * Use .html instead of text to append html content * Removing one error message: there's no error to show, uneeded * Fix toggle logic of the purchase message * fix linting issue * update success copy * simple-payments: small coding improvements in output_shortcode() * simple-payments: do not use underscore in css class https://make.wordpress.org/core/handbook/best-practices/coding-standards/css/#selectors * simple-payments: minor improvements defining endpoints * simple-payments: use `<p>` tag for description and price #7500 (comment) * simple-payments: minor improvements * simple-payments: add purchase-box container. improve paypal button styles. * Simple Payments: update error message handling (#7503) - display success message from backend ( D6514-code ) - display all error messages * simple-pyaments: wrap all text into `<p>` elems * simple-payments: move globals as PaypalExpressCheckout properties * simple-payments: coding improvementes. * simple-payments: minor code improvements * rebase: squash -> "simple-payments: move globals as PaypalExpressCheckout properties" * Remove wpautop for Simple Payments product content/description (#7507) * Simple payments: image (#7508) Introduces an image to a payment button * Disable default sandboxing * simple-payments: user camel-case convention * reenable sandbox * Add env handling * Simple Payments: Style shortcode * simple-payments: inject msgs in the right place * simple-payments: show error in onAuthorize callback * fix additional error messages * Simple Payments: Modify message style * fix empty join call * Simple Payments: Reset iframe margin * wrap default error message * Implement review feedback * Add min field * SimplePayments: add formatted price meta data (#7521) Output `spay_formatted_price` if present * somple-payments: improve-error-handling * simple-payments: check processErrorMessage() param * Fixed lint errors. * Simple Payments: return wpcom blog_id if code is running on wpcom (#7524) * Simple Payments: add method to process success messages (#7528) Fixes styling of success messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
Now:
Testing
Perform a purchase of some product in Simple Payments. Does the success message text shows in white color?