Merged
Conversation
…yle-fixes Simple payments/shortcode style fixes
…ic/jetpack into simple-payments/shortcode-style
Simple Payments: Style shortcode
Output `spay_formatted_price` if present
zinigor
approved these changes
Jul 25, 2017
Contributor
zinigor
left a comment
There was a problem hiding this comment.
Tested, works well, changes look good, thanks!
…ng-client-side SimplePayments: improve-error-handling
Fixes styling of success messages.
| wp_register_script( 'paypal-checkout-js', 'https://www.paypalobjects.com/api/checkout.js', array(), null, true ); | ||
| wp_register_script( 'paypal-express-checkout', plugins_url( '/paypal-express-checkout.js', __FILE__ ), | ||
| array( 'jquery', 'paypal-checkout-js' ), self::$version ); | ||
| wp_enqueue_style( 'simple-payments', plugins_url( '/simple-payments.css', __FILE__ ) ); |
Contributor
There was a problem hiding this comment.
Why is this enqueueing, rather than just registering?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces Simple Payments feature.
This is an "ecommerce light" feature.
Stark team: we dont merge this. The Jetpack release lead does. Dont merge!
More details in projectpaymentbutton-p2
Warning: on calypso side, there still is work to do, but we are pretty certain this JP piece is production-ready.
Since there is no UI in JP, users will start using it when we relese it in calypso.
We are still tweaking CSS, otherwise we consider it ready
Testing
artur.piszek+test2@automattic.com)localStorage.setItem('simple-payments-env', 'sandbox' );to switch to Sandbox mode, refreshartur.piszek+test@automattic.com, pass:potato123)