SimplePayments: improve-error-handling#7525
Merged
retrofox merged 2 commits intofeature/simple-paymentsfrom Jul 25, 2017
Merged
SimplePayments: improve-error-handling#7525retrofox merged 2 commits intofeature/simple-paymentsfrom
retrofox merged 2 commits intofeature/simple-paymentsfrom
Conversation
lamosty
reviewed
Jul 25, 2017
jhnstn
requested changes
Jul 25, 2017
| jQuery.post( PaypalExpressCheckout.getCreatePaymentEndpoint( blogId ), payload ) | ||
| .done( function( paymentResponse ) { | ||
| if ( ! paymentResponse ) { | ||
| PaypalExpressCheckout.showError( PaypalExpressCheckout.processErrorMessage(), domId ); |
Member
There was a problem hiding this comment.
This will cause an error :(
PaypalExpressCheckout.processErrorMessage currently expects the first argument to be an object: https://github.com/Automattic/jetpack/pull/7525/files#diff-ad5f66f7ce71d416f68444397b6e59cdR91
Just need to update processErrorMessage. This should work var error = errorResponse && errorResponse.responseJSON;
Contributor
Author
done |
jhnstn
approved these changes
Jul 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR request adds some checks when the response is processed in order to avoid javascript errors.