Skip to content

Markdown: enable markdown on posts automatically on activation. #6548

Merged
dereksmart merged 1 commit intomasterfrom
update/option-enable-markdown-posts
Mar 6, 2017
Merged

Markdown: enable markdown on posts automatically on activation. #6548
dereksmart merged 1 commit intomasterfrom
update/option-enable-markdown-posts

Conversation

@eliorivero
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero commented Mar 2, 2017 •
edited by dereksmart
Loading

Fixes #6442

Changes proposed in this Pull Request:

  • Enables markdown on posts and pages automatically if the module is active.

This was a regression with the new UI, since there are no options to turn it on in the new UI.

@eliorivero eliorivero added Admin Page React-powered dashboard under the Jetpack menu [Feature] Markdown [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended labels Mar 2, 2017
@eliorivero eliorivero self-assigned this Mar 2, 2017
@eliorivero eliorivero requested a review from jeherve March 2, 2017 14:11
@jeherve jeherve modified the milestone: 4.7 Mar 2, 2017
dereksmart
dereksmart requested changes Mar 3, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDITED:

@eliorivero Thanks for adding the checkbox for posts. However I believe intended behavior is to auto-enable markdown for posts if the thing is active. Looks like it was maybe removed as part of this change (the filter maybe)? ea8c553#diff-95a37d58f692267f7ab8aceccf71e186L17

I think we can remove the checkbox again but only as long as we're sure markdown is always enabled for posts when the module is active, because currently it's not.

@eliorivero
Copy link
Copy Markdown
Contributor Author

eliorivero commented Mar 3, 2017

Based on a convo we just had with @dereksmart, this PR will be updated to turn on the option wpcom_publish_posts_with_markdown when the module is activated.

This behavior will be later removed in the new UI since we have different toggles to enable Markdown for posts and for comments so it's not necessary there. #6396

@eliorivero eliorivero added [Status] In Progress [Status] Needs Review This PR is ready for review. and removed [Status] Needs Review This PR is ready for review. [Status] In Progress labels Mar 6, 2017
@eliorivero
Copy link
Copy Markdown
Contributor Author

eliorivero commented Mar 6, 2017

Added code so the wpcom_publish_posts_with_markdown option is automatically set when Markdown is activated using the endpoint.

@eliorivero eliorivero force-pushed the update/option-enable-markdown-posts branch from afd1987 to d7afc9e Compare March 6, 2017 15:39
@dereksmart dereksmart changed the title Settings - Markdown: add option to enable it for post editor Markdown: enable markdown on posts automatically on activation. Mar 6, 2017
@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 6, 2017
jeherve
jeherve approved these changes Mar 6, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Merging.

@dereksmart dereksmart merged commit cfd18c2 into master Mar 6, 2017
@dereksmart dereksmart deleted the update/option-enable-markdown-posts branch March 6, 2017 16:23
@dereksmart dereksmart removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 6, 2017
@dereksmart
Copy link
Copy Markdown
Contributor

dereksmart commented Mar 6, 2017

Merged to 4.7 5fb1636

jeherve added a commit that referenced this pull request Mar 8, 2017
@jeherve
Markdown: enable for posts whenever the module is active.
d528053 
Also remove the option from Settings > Writing.

Fixes #6605

Related:
- #6406
- #6548
@jeherve jeherve mentioned this pull request Mar 8, 2017
Merged
dereksmart pushed a commit that referenced this pull request Mar 9, 2017
@jeherve @dereksmart
Markdown: enable for posts whenever the module is active. (#6608)
73f17b2 
* Markdown: enable for posts whenever the module is active.

Also remove the option from Settings > Writing.

Fixes #6605

Related:
- #6406
- #6548

* Markdown: make sure posts markdown is re-enabled on upgrade

* Remove setting checkbox from writing options page
dereksmart pushed a commit that referenced this pull request Mar 9, 2017
@jeherve @dereksmart
Markdown: enable for posts whenever the module is active. (#6608)
71752a9 
* Markdown: enable for posts whenever the module is active.

Also remove the option from Settings > Writing.

Fixes #6605

Related:
- #6406
- #6548

* Markdown: make sure posts markdown is re-enabled on upgrade

* Remove setting checkbox from writing options page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

@dereksmart dereksmart dereksmart approved these changes

Assignees

@eliorivero eliorivero

Labels

Admin Page React-powered dashboard under the Jetpack menu Bug When a feature is broken and / or not performing as intended [Feature] Markdown [Pri] BLOCKER

Projects

None yet

Milestone

4.7

Development

Successfully merging this pull request may close these issues.

3 participants

@eliorivero @dereksmart @jeherve