Settings UI: allow to independently toggle Markdown for posts and for comments #6396
Merged
eliorivero merged 2 commits intofeature/settings-overhaulfrom Feb 15, 2017
Merged
Conversation
8e1ea71 to
3cda3ce
Compare
tyxla
approved these changes
Feb 14, 2017
Member
tyxla
left a comment
There was a problem hiding this comment.
Works like a charm 👍 Thanks for that!
Just a side note: I think we don't really need to disable the module at all - after all, it doesn't do any damage if all post types are disabled, but the module is enabled, right? But that's your call really.
Contributor
Author
|
It's better to disable it so Jetpack doesn't attempt to load the file. |
…forcefully enables Markdown for posts every time the option is about to be written.
…pendent of each other
8506a3a to
8c1ba3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6311
See p6TEKc-HQ-jpopdesignp2, comment-2128 by @tyxla
Changes proposed in this Pull Request:
markdown.phpthat forcefully enables Markdown for posts every time the option is attempted to be written.🗒 the first commit won't be needed if it's merged in #6406
Testing instructions: