Widget Visibility: Fixed several issues...#3210
Closed
atrus1701 wants to merge 4 commits intoAutomattic:masterfrom
Closed
Widget Visibility: Fixed several issues...#3210atrus1701 wants to merge 4 commits intoAutomattic:masterfrom
atrus1701 wants to merge 4 commits intoAutomattic:masterfrom
Conversation
Member
Contributor
Author
|
I can resubmit the changes as 5 smaller Pull Requests that refer to this larger Pull Request. Would you like for me to do that? |
Member
|
@atrus1701 If you don't mind, that'd be great! Thanks! |
Contributor
Author
|
Sorry for the late reply, but I will make the new Pull Requests. Should be done by the end of the day. |
This was referenced Jan 18, 2016
Member
|
Thanks! Closing this PR then. |
This was referenced Feb 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had some downtime during my trial and it was suggested I work on a few simple issues. I found the following five issues related Widget Visibility in the GitHub issues.
Undefined index has_children in widget-conditions.php
Widget Visibility for “All taxonomy pages” and “All [custom tax] pages” not working
Widget Visibility: support custom post type archive pages
Widget Visibility for Custom Post Type for Pages and Custom Taxonomies Concurrently
Widget Visibility: add an AND condition
I found solutions to all of the issues and have tested them on my test site several times.