Widget Visibility: add ability to match ALL conditions.#3289
Widget Visibility: add ability to match ALL conditions.#3289atrus1701 wants to merge 1 commit intoAutomattic:masterfrom
Conversation
- Add the option to match all conditions specified for the widget. - see Automattic#852.
| <span class="condition-conjunction"><?php echo esc_html_x( 'or', 'Shown between widget visibility conditions.', 'jetpack' ); ?></span> | ||
| <span class="condition-conjunction"> | ||
| <?php | ||
| // echo esc_html_x( 'or', 'Shown between widget visibility conditions.', 'jetpack' ); |
There was a problem hiding this comment.
Ideally, we would use a bit of Javascript to alternate this value between "or" and "and" depending on the state of the checkbox that was introduced.
If we are going to omit this label instead, we should remove this line rather than comment out the text.
|
From a functionality standpoint, this looks good to me and seems to work well in each case that I tested. However, I'd like to see a bit of input on how the "Match All" checkbox is positioned. I also left an inline comment about using a bit of Javascript to alter the "and" and "or" values of the conjunction label. Perhaps a second set of experienced eyes on this and/or a quick design review would be good. |
|
Bumping this to 4.5 while we wait for @atrus1701 to reply-- @atrus1701, if you can address Rich's concerns, we'd love to get this into 4.5 which will be released next month. Thanks! |
|
Can you add a quick screenshot? |
|
Closing in favor of #6327 |
This fixes issue #852.
This is related to Pull Request #3210. This original Pull Request contained several fixes that are being broken out into several smaller requests.