Skip to content

Widget Visibility: fix issues with visibility on taxonomy pages.#3288

Closed
atrus1701 wants to merge 1 commit intoAutomattic:masterfrom
atrus1701:widget-visiblity-fix-3020
Closed

Widget Visibility: fix issues with visibility on taxonomy pages.#3288
atrus1701 wants to merge 1 commit intoAutomattic:masterfrom
atrus1701:widget-visiblity-fix-3020

Conversation

@atrus1701
Copy link
Copy Markdown
Contributor

@atrus1701 atrus1701 commented Jan 18, 2016

This fixes issue #3020 and related issue #2170.

  • When selecting "Taxonomy => All taxonomy pages" or "Taxonomy => All [custom tax] pages", the widget would not be shown / hidden correctly. Reworked the "tag", "category", and "taxonomy" rules to correctly show / hide the widget.

This is related to Pull Request #3210. This original Pull Request contained several fixes that are being broken out into several smaller requests.

@atrus1701
Widget Visibility: fix issues with visibility on taxonomy pages.
9497cca 
- When selecting "Taxonomy => All taxonomy pages" or "Taxonomy => All
[custom tax] pages", the widget would not be shown / hidden correctly.
Reworked the "tag", "category", and "taxonomy" rules to correctly show /
hide the widget.
- see issue Automattic#3020 and related issue Automattic#2170.
@atrus1701 atrus1701 mentioned this pull request Jan 18, 2016
Closed
@jeherve jeherve added Bug When a feature is broken and / or not performing as intended [Feature] Widget Visibility [Status] Needs Review This PR is ready for review. labels Jan 18, 2016
@jeherve jeherve added this to the 3.9.1 milestone Jan 18, 2016
@zinigor zinigor mentioned this pull request Jan 18, 2016
Closed
@kraftbj kraftbj modified the milestones: 3.9.1, 3.9.2 Jan 21, 2016
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Feb 17, 2016

@atrus1701 Could you rebase this PR?

Thanks!

@dereksmart dereksmart modified the milestones: 3.9.2, 3.9.3 Feb 24, 2016
@guillaumemolter
Copy link
Copy Markdown

guillaumemolter commented Mar 2, 2016

@atrus1701 yes please rebase so it can be merged 👍

@zinigor zinigor modified the milestones: 3.10, 3.9.3 Mar 3, 2016
@jeherve jeherve mentioned this pull request Mar 16, 2016
Closed
@samhotchkiss samhotchkiss modified the milestones: 3.10, Widget Visibility Next Mar 28, 2016
@jeherve jeherve modified the milestones: 4.2, Widget Visibility Next Jun 17, 2016
@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Jul 6, 2016
@jeherve jeherve modified the milestones: 4.3, 4.2 Jul 6, 2016
@richardmuscat richardmuscat modified the milestones: 4.3, 4.4 Jul 7, 2016
@samhotchkiss samhotchkiss modified the milestones: Not Currently Planned, 4.4 Nov 9, 2016
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Nov 30, 2016

#5781

@zinigor zinigor mentioned this pull request Feb 8, 2017
Merged
@zinigor
Copy link
Copy Markdown
Contributor

zinigor commented Feb 8, 2017

Closing in favor of #6326

@zinigor zinigor closed this Feb 8, 2017
MisterWP
MisterWP reviewed Feb 27, 2017
View reviewed changes
Copy link
Copy Markdown

@MisterWP MisterWP left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be fixed on 4.7 right ? Thanks !

@jeherve
Copy link
Copy Markdown
Member

jeherve commented Feb 27, 2017

@MisterWP Yes, the change will be part of the next Jetpack release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MisterWP MisterWP MisterWP left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Widget Visibility [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@atrus1701 @jeherve @guillaumemolter @zinigor @MisterWP @kraftbj @samhotchkiss @richardmuscat @dereksmart