Skip to content

Blocks Settings: Make Blocks toggleable (and searchable)#23630

Merged
dereksmart merged 10 commits intomasterfrom
update/blocks-settings-searchable
Mar 28, 2022
Merged

Blocks Settings: Make Blocks toggleable (and searchable)#23630
dereksmart merged 10 commits intomasterfrom
update/blocks-settings-searchable

Conversation

@dereksmart
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart commented Mar 25, 2022 •
edited
Loading

Follow-up from #23470, this adds "blocks" as a classic Jetpack module. This allows users to toggle off, if desired. It also allows us to surface the blocks when searching in settings.

image

Keeping this in progress until 23470 is merged and then will rebase.

Changes proposed in this Pull Request:

  • Mocks a bit of module data in the initial state to define some search terms.
  • Use the mocked data structure to make the settings card searchable.
  • Blocks can now be disabled via this setting.

Jetpack product discussion

N/a

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • We're going to want to ensure that blocks are still on by default after upgrading to the new version, and for brand new sites.
  • Search for the terms in settings, does the card show up?
  • Try deactivating/reactivating, test if it's actually doing expected.

jeherve and others added 3 commits March 16, 2022 18:48
@jeherve
Dashboard: add highlight of Jetpack blocks to the settings page
bc6fff9 
Related: #23468

Let's promote that Jetpack includes blocks in the Jetpack settings, in the Jetpack dashboard.
@jeherve @coder-karen
Update projects/plugins/jetpack/_inc/client/writing/composing.jsx
f3a9674 
Co-authored-by: Karen Attfield <karenlattfield@gmail.com>
@dereksmart
Make the Blocks settings card searchable.
a38da4c
@dereksmart dereksmart added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress Admin Page React-powered dashboard under the Jetpack menu labels Mar 25, 2022
@dereksmart dereksmart added this to the jetpack/10.8 milestone Mar 25, 2022
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Mar 25, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 25, 2022 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: April 5, 2022.
  • Scheduled code freeze: March 29, 2022.

@dereksmart dereksmart changed the title Make the new Blocks settings card searchable Blocks: Convert to a module and make them toggleable (and searchable) Mar 25, 2022
jeherve
jeherve reviewed Mar 25, 2022
View reviewed changes
@jeherve jeherve mentioned this pull request Mar 25, 2022
Closed
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Mar 25, 2022

I tried #23636 as a bit of an alternative to this, borrowing ideas but also relying on an option.

@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Mar 28, 2022

Caution: This PR has changes that must be merged to WordPress.com
Hello dereksmart! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D77666-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@dereksmart dereksmart added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Mar 28, 2022
@dereksmart dereksmart changed the title Blocks: Convert to a module and make them toggleable (and searchable) Blocks Settings: Make Blocks toggleable (and searchable) Mar 28, 2022
jeherve
jeherve approved these changes Mar 28, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, works great! I suppose we could add some comments here and there to explain that "fake module" we got ourselves here, but that can be done in a follow-up PR.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 28, 2022
@dereksmart dereksmart merged commit 3e27eb6 into master Mar 28, 2022
@dereksmart dereksmart deleted the update/blocks-settings-searchable branch March 28, 2022 17:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 28, 2022

Great news! One last step: head over to your WordPress.com diff, D77666-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 28, 2022
@jeherve jeherve added the [Status] Needs Testing We need to add this change to the testing call for this month's release label Mar 28, 2022
@dereksmart
Copy link
Copy Markdown
Contributor Author

dereksmart commented Mar 28, 2022

Deployed in r242662-wpcom

@samiff samiff removed the [Status] Needs Testing We need to add this change to the testing call for this month's release label Mar 28, 2022
@jeherve jeherve mentioned this pull request Aug 7, 2023
Closed
@jeherve jeherve mentioned this pull request Jan 12, 2024
Merged
3 tasks
@kraftbj kraftbj mentioned this pull request Sep 17, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@dereksmart dereksmart

Labels

Admin Page React-powered dashboard under the Jetpack menu Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files

Projects

None yet

Milestone

jetpack/10.8

Development

Successfully merging this pull request may close these issues.

4 participants

@dereksmart @jeherve @matticbot @samiff