Skip to content

Dashboard: allow toggling off blocks from Jetpack settings#23636

Closed
jeherve wants to merge 8 commits intomasterfrom
update/settings-blocks-admin
Closed

Dashboard: allow toggling off blocks from Jetpack settings#23636
jeherve wants to merge 8 commits intomasterfrom
update/settings-blocks-admin

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Mar 25, 2022

Alternative to #23630

Changes proposed in this Pull Request:

This is not quite working just yet, but I wanted to try something else:

  • Add a new fake module, just like in Blocks Settings: Make Blocks toggleable (and searchable) #23630, so the feature can be searched.
  • Create a new blocks_disabled Jetpack option, that will synced.
  • Allow updating that options from the Settings v4 endpoint.
  • Add a new toggle that plays with that option.
  • Short-circuit Gutenberg when the option is set.

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Start from a site that's connected to WordPress.com.
  • Apply this branch
  • Go to Posts > Add New
  • The Jetpack blocks should still be available
  • Go to Jetpack > Settings
  • Search for "Blocks"
  • You should find the new toggle, as well as the link to the post editor.
  • When clicking on the toggle, the option should be triggered, the link to the post editor should disappear, the toggle status should be updated, and the blocks should disappear from the post editor.

@jeherve jeherve added Admin Page React-powered dashboard under the Jetpack menu [Feature] Comment Likes [Pri] Low [Status] In Progress Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Mar 25, 2022
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Mar 25, 2022

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D77594-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added [Package] Options This package no longer exists in the monorepo. It was merged into [Package] Connection. [Package] Sync [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Mar 25, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 25, 2022 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: April 5, 2022.
  • Scheduled code freeze: March 29, 2022.

@jeherve jeherve mentioned this pull request Mar 25, 2022
Merged
@jeherve
Copy link
Copy Markdown
Member Author

jeherve commented Mar 28, 2022

closing in favor of #23630

@jeherve jeherve closed this Mar 28, 2022
@jeherve jeherve deleted the update/settings-blocks-admin branch March 28, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jeherve jeherve

@dereksmart dereksmart

Labels

Admin Page React-powered dashboard under the Jetpack menu Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Comment Likes [Package] Options This package no longer exists in the monorepo. It was merged into [Package] Connection. [Package] Sync [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low Touches WP.com Files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeherve @matticbot @dereksmart