Skip to content

Dashboard: add highlight of Jetpack blocks to the settings page#23470

Merged
jeherve merged 4 commits intomasterfrom
add/blocks-card-settings
Mar 25, 2022
Merged

Dashboard: add highlight of Jetpack blocks to the settings page#23470
jeherve merged 4 commits intomasterfrom
add/blocks-card-settings

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Mar 16, 2022 •
edited
Loading

Changes proposed in this Pull Request:

Related: #23468

Let's promote that Jetpack includes blocks in the Jetpack settings, in the Jetpack dashboard.

image

Later on, we can add a toggle here that would act as a main toggle from this:

jetpack/projects/plugins/jetpack/class.jetpack-gutenberg.php

Lines 451 to 474 in a09c00e

/**
* Check whether conditions indicate Gutenberg Extensions (blocks and plugins) should be loaded
*
* Loading blocks and plugins is enabled by default and may be disabled via filter:
* add_filter( 'jetpack_gutenberg', '__return_false' );
*
* @since 6.9.0
*
* @return bool
*/
public static function should_load() {
if ( ! Jetpack::is_connection_ready() && ! ( new Status() )->is_offline_mode() ) {
return false;
}
/**
* Filter to disable Gutenberg blocks
*
* @since 6.5.0
*
* @param bool true Whether to load Gutenberg blocks
*/
return (bool) apply_filters( 'jetpack_gutenberg', true );
}

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Go to Jetpack > Settings > Writing
  • You should see a card promoting Jetpack blocks, with a link to the block editor. Give it a try.
  • Go to Plugins > Add New, and install / activate the Classic Editor plugin.
  • Go back to Jetpack > Settings > Writing, the blocks card should be gone.

@jeherve
Dashboard: add highlight of Jetpack blocks to the settings page
bc6fff9 
Related: #23468

Let's promote that Jetpack includes blocks in the Jetpack settings, in the Jetpack dashboard.
@jeherve jeherve added Admin Page React-powered dashboard under the Jetpack menu [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Low [Status] Needs Review This PR is ready for review. Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Mar 16, 2022
@jeherve jeherve self-assigned this Mar 16, 2022
@coder-karen coder-karen self-requested a review March 22, 2022 07:59
coder-karen
coder-karen reviewed Mar 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@coder-karen coder-karen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

158655527-81b89c5e-98dc-4ca5-aba9-734cb94a2709

^ I wonder if the link can be in the same settings group as the initial information about Jetpack blocks just above? The separating line leads me to think these two sections aren't necessarily related.

Comment thread projects/plugins/jetpack/_inc/client/writing/composing.jsx Outdated
@coder-karen coder-karen added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Needs Review This PR is ready for review. and removed [Status] Needs Review This PR is ready for review. labels Mar 22, 2022
@github-actions github-actions Bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Mar 22, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 22, 2022 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: April 5, 2022.
  • Scheduled code freeze: March 29, 2022.

@jeherve @coder-karen
Update projects/plugins/jetpack/_inc/client/writing/composing.jsx
f3a9674 
Co-authored-by: Karen Attfield <karenlattfield@gmail.com>
@jeherve
Copy link
Copy Markdown
Member Author

jeherve commented Mar 22, 2022

^ I wonder if the link can be in the same settings group as the initial information about Jetpack blocks just above? The separating line leads me to think these two sections aren't necessarily related.

I had considered that as well, but opted to follow the way we do things for other settings, like the Portfolio and Testimonial settings right below the block settings:

image

@jeherve jeherve added [Status] Needs Review This PR is ready for review. [Status] Needs Copy Review Copy has been added. Marketing will be notified for a copy review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Mar 22, 2022
@coder-karen coder-karen removed the [Status] Needs Review This PR is ready for review. label Mar 23, 2022
@jeherve jeherve added this to the jetpack/10.8 milestone Mar 25, 2022
dereksmart
dereksmart approved these changes Mar 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you. Incoming follow-up PR to make this searchable.

@dereksmart dereksmart mentioned this pull request Mar 25, 2022
Merged
@jeherve jeherve enabled auto-merge (squash) March 25, 2022 15:27
@jeherve
Copy link
Copy Markdown
Member Author

jeherve commented Mar 25, 2022

Master merge to try to unblock things.

@jeherve jeherve merged commit 5a3a4b7 into master Mar 25, 2022
@jeherve jeherve deleted the add/blocks-card-settings branch March 25, 2022 16:11
@github-actions github-actions Bot removed [Status] Editorial Input Requested [Status] Needs Copy Review Copy has been added. Marketing will be notified for a copy review. labels Mar 25, 2022
@jeherve jeherve mentioned this pull request Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dereksmart dereksmart dereksmart approved these changes

@coder-karen coder-karen coder-karen approved these changes

Assignees

@jeherve jeherve

Labels

Admin Page React-powered dashboard under the Jetpack menu Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low

Projects

None yet

Milestone

jetpack/10.8

Development

Successfully merging this pull request may close these issues.

3 participants

@jeherve @dereksmart @coder-karen