Extensions: update webpack configuration to prevent plugin conflicts by creativecoder · Pull Request #17312 · Automattic/jetpack

creativecoder · 2020-09-29T22:14:30Z

Changes proposed in this Pull Request:

Adds a custom setting for output.jsonpFunction to the webpack configuration for building extensions
This prevents conflicts in the default webpackJsonp JavaScript global when other WordPress plugins also load JavaScript built with webpack

See https://v4.webpack.js.org/configuration/output/#outputjsonpfunction for more information about the webpack configuration.

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

I've only been able to replicate #17289 with the release build of Jetpack, not in development environments, so I'm not sure how to test that this definitely fixes the issue.

But more generally, you can test by

Build Jetpack extensions with jetpack build plugin and select jetpack.
Load a post or page in the editor with your local Jetpack development site. Look at the output JS for extensions (such as editor-beta.js). You should see window["webpackJsonpJetpack"] in the built JS, rather than window["webpackJsonp"]

Proposed changelog entry for your changes:

Updates the webpack configuration for jsonpFunction when building JavaScript for extensions.

matticbot · 2020-09-29T22:14:35Z

Caution: This PR has changes that must be merged to WordPress.com
Hello creativecoder! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D50391-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

jetpackbot · 2020-09-29T22:17:18Z

Scheduled Jetpack release: November 10, 2020.
Scheduled code freeze: November 3, 2020

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17312

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against fc5a9ae

creativecoder · 2020-10-07T23:05:52Z

Related PR: Automattic/wp-calypso#46252

creativecoder · 2020-10-26T03:33:21Z

Note that Automattic/wp-calypso#46252 is merged, but the @automattic/calypso-build package still needs a release for the changes to be available through npm.

I've updated the description and marked this ready for review.

creativecoder · 2020-10-26T03:57:22Z

PR for the update to @automattic/calypso-build

jeherve · 2020-10-26T16:52:08Z

Noting that we won't be able to update calypso-build just yet, even when a 6.4.0 becomes available. We'll need to fix the issues that prevent us from updating to 6.3.0 first:
#16845

creativecoder · 2020-10-27T20:52:26Z

Noting that we won't be able to update calypso-build just yet

Ugh.. okay good to know. I'm wondering if we should prioritize that sooner rather than later given the severity of the related bug (#17289)

jeherve · 2020-11-04T14:33:49Z

yarn link the @automattic/calypso-build package from wp-calypso package you have locally to a local Jetpack development environment

How did you get this to work? I get the following message when I give this a try:

yarn link @automattic/calypso-build
yarn link v1.22.10
error No registered package found called "@automattic/calypso-build".

creativecoder · 2020-11-05T23:11:07Z

How did you get this to work?

@jeherve my process was

From packages/calypso-build directory in wp-calypso repo, run yarn link (note that you may first need to yarn unlink if you've done this previously). You should see a message

success Registered "@automattic/calypso-build".
info You can now run `yarn link "@automattic/calypso-build"` in the projects where you want to use this package and it will be used instead.

From jetpack repo root, run yarn link "@automattic/calypso-build". You should see

success Using linked package for "@automattic/calypso-build".

jeherve · 2021-01-14T17:15:07Z

Noting that this will also be fixed in Core, as per this PR:
WordPress/gutenberg#27985

creativecoder · 2021-05-25T19:51:30Z

Noting that this PR is still blocked by required upgrade of calypso-build. Most recent PR for that upgrade is #19374.

jeherve · 2021-06-10T12:14:16Z

Noting that this PR is still blocked by required upgrade of calypso-build. Most recent PR for that upgrade is #19374.

The update is now complete. 🎉

jeherve

Do you think you could rebase, now that the Calypso build update is merged?

github-actions · 2021-06-10T16:15:29Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ All commits were linted before commit.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

Next scheduled release: July 6, 2021.
Scheduled code freeze: June 28, 2021.

creativecoder · 2021-06-10T17:18:55Z

This should now be ready to go

anomiex

Seems ok to me.

PR was rebased.

github-actions · 2021-06-11T15:11:46Z

Great news! One last step: head over to your WordPress.com diff, D50391-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

creativecoder · 2021-06-11T16:37:14Z

r227168-wpcom

matticbot added the Touches WP.com Files label Sep 29, 2020

creativecoder added the [Status] In Progress label Sep 29, 2020

creativecoder marked this pull request as ready for review September 29, 2020 22:15

creativecoder mentioned this pull request Sep 29, 2020

Extensions: Jetpack blocks disappear when ActiveCampaign plugin is activated #17289

Closed

jeherve added the [Extension] External Media Extend all block editor media tools to support external providers label Sep 30, 2020

jeherve assigned creativecoder Sep 30, 2020

creativecoder changed the title ~~External Media: Remove lodash dependency to fix js error~~ Extensions: update webpack configuration to prevent plugin conflicts Oct 26, 2020

creativecoder requested a review from a team October 26, 2020 03:30

creativecoder added [Type] Infrastructure [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Oct 26, 2020

jeherve added Build [Status] Blocked / Hold and removed [Type] Infrastructure [Status] Needs Review This PR is ready for review. labels Oct 26, 2020

jeherve removed the [Status] Blocked / Hold label Jun 10, 2021

matticbot removed the Touches WP.com Files label Jun 10, 2021

jeherve added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jun 10, 2021

jeherve previously requested changes Jun 10, 2021

View reviewed changes

Update webpack configuration to customize jsonp function for extensions

fd30f8c

creativecoder force-pushed the fix/activecampaign-js-error branch from fc5a9ae to fd30f8c Compare June 10, 2021 16:14

matticbot added the Touches WP.com Files label Jun 10, 2021

github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jun 10, 2021

creativecoder added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jun 10, 2021

Add changelog file

288d386

creativecoder requested a review from jeherve June 10, 2021 17:19

sdixon194 added this to the jetpack/9.9 milestone Jun 10, 2021

anomiex approved these changes Jun 11, 2021

View reviewed changes

sdixon194 added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jun 11, 2021

creativecoder merged commit 940152f into master Jun 11, 2021

creativecoder deleted the fix/activecampaign-js-error branch June 11, 2021 15:10

github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jun 11, 2021

Conversation

creativecoder commented Sep 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this Pull Request:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Proposed changelog entry for your changes:

Uh oh!

matticbot commented Sep 29, 2020

Uh oh!

jetpackbot commented Sep 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

creativecoder commented Oct 7, 2020

Uh oh!

creativecoder commented Oct 26, 2020

Uh oh!

creativecoder commented Oct 26, 2020

Uh oh!

jeherve commented Oct 26, 2020

Uh oh!

creativecoder commented Oct 27, 2020

Uh oh!

jeherve commented Nov 4, 2020

Uh oh!

creativecoder commented Nov 5, 2020

Uh oh!

jeherve commented Jan 14, 2021

Uh oh!

creativecoder commented May 25, 2021

Uh oh!

jeherve commented Jun 10, 2021

Uh oh!

jeherve left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

creativecoder commented Jun 10, 2021

Uh oh!

anomiex left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 11, 2021

Uh oh!

creativecoder commented Jun 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

creativecoder commented Sep 29, 2020 •

edited

Loading

jetpackbot commented Sep 29, 2020 •

edited

Loading

github-actions bot commented Jun 10, 2021 •

edited

Loading

creativecoder commented Jun 11, 2021 •

edited

Loading