Caution: This PR has changes that must be merged to WordPress.com
Hello renovate[bot]! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D48165-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against cc28846

Looks like the dependency updates bundled in that update cause our block tests to break.

cc @brbrr

@brbrr Could you have a look into this when you can spare some time? It might help unblock the IE11 canary on WP.com 😊 (see Automattic/wp-calypso#41206 (comment) and #17127)

Ok, so the tests are passing locally, but for some reason, they are failing with the same error in Travis.

Unfortunately, I was not been able to figure out the problem here. What I found:

jest-jasmine (that is shipped together with jest) calls one of the internal jest methods, which apparently does not exists: TypeError: (0 , _testResult.createEmptyTestResult) is not a function

createEmptyTestResult is a method from @jest/test-result

while checking dependencies, I noticed that the latest calypso-build pulling older @jest/test-result version which does not include createEmptyTestResult. It comes from jest-enzyme package. But it was not updated between 6.1.0-6.3.0, The problem not with the package itself.

My guess would be that problem comes from webpack/babel package updates/configs, and unfortunately, I have no idea what might be wrong here.

This conflict was introduced in 6.2.0

@scinos @jsnajdr any idea what might have changed in 6.2.0 release that could affect jest transpilation?

@brbrr what do I need to run locally to reproduce the issue? There are several kinds of tests and I don't know which is the failing one.

@jsnajdr ah, sorry. I should have provided more context upfront

yarn jest extensions would run block related tests that are failing for this PR

It seems that the Jetpack yarn.lock lockfile is not in a good shape.

The _testResult.createEmptyTestResult is almost certainly caused by two duplicated versions of @jest/test-results. This PR does quite a lot of changes in yarn.lock, so the duplication may be a result of that.

While trying to reproduce with yarn run test-extensions, I encountered two other instances of a similar error, this time with @wordpress/* packages:

• there was an older version of @wordpress/compose in the tree, one that doesn't support the useInstanceId hook. Tests failed because the export was missing.
• the @wordpress/data library was duplicated, causing a store (core/blocks) to register in one instance, and then trying to access it from another instance, causing select( 'core/blocks' ).getBlockTypes() to fail (select( 'core/blocks' ) returns null)

@scinos Could we introduce some of the tools that we use in Calypso also to the Jetpack repo? Deduplication, yarn doctor and Calypso doctor...

Probably the best next step here is to properly upgrade and dedupe the @wordpress/* packages.

I reverted unrelated changes just in case

To recap, this likely needs a @wordpress/ monorepo upgrade to unblock it. We have renovate's #16763, but that doesn't work because of a few other required changes that @brbrr worked on in #17072 until we got blocked -- see p9dueE-1Q7-p2.

This renovate PR is too old: renovate loses track of its own PRs when they're beyond the latest 1000 in the repo. See renovate issue #4803.

Closing the PR so renovate can re-create it.