Skip to content

WordPress.com API: take new option names into account#16568

Merged
jeherve merged 1 commit into
masterfrom
update/wpcom-api-new-options
Jul 24, 2020
Merged

WordPress.com API: take new option names into account#16568
jeherve merged 1 commit into
masterfrom
update/wpcom-api-new-options

Conversation

@jeherve

@jeherve jeherve commented Jul 24, 2020

Copy link
Copy Markdown
Member

Changes proposed in this Pull Request:

Primary issues: #15388 and #16099

  • Note: indenting is off in some of those files. In a separate PR I'll aim to fix all indenting in these big arrays.

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • N/A

Testing instructions:

From 2 sites, both running this branch, one running WP 5.4.2 and another WP 5.5:

Proposed changelog entry for your changes:

  • WordPress.com REST API: adjust API response based on language improvements in WordPress 5.5.

@jeherve jeherve added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] WPCOM API [Status] Needs Review This PR is ready for review. [Pri] Normal labels Jul 24, 2020
@jeherve jeherve added this to the 8.8 milestone Jul 24, 2020
@jeherve jeherve self-assigned this Jul 24, 2020
@matticbot

matticbot commented Jul 24, 2020

Copy link
Copy Markdown
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D46864-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jetpackbot

jetpackbot commented Jul 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator
Warnings
⚠️

pre-commit hook was skipped for one or more commits

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16568

Generated by 🚫 dangerJS against 21ad5fd

@jeherve jeherve mentioned this pull request Jul 24, 2020
Closed
14 tasks
@kraftbj kraftbj mentioned this pull request Jul 24, 2020
Open
7 tasks
@jeherve jeherve force-pushed the update/wpcom-api-new-options branch from 8d27837 to 21ad5fd Compare July 24, 2020 17:16
mdbitz
mdbitz approved these changes Jul 24, 2020
View reviewed changes

@mdbitz mdbitz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Approved !more settings!

@mdbitz mdbitz added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jul 24, 2020
@jeherve

jeherve commented Jul 24, 2020

Copy link
Copy Markdown
Member Author

r210988-wpcom

@jeherve jeherve merged commit af7979d into master Jul 24, 2020
@jeherve jeherve deleted the update/wpcom-api-new-options branch July 24, 2020 17:47
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jul 24, 2020
jeherve added a commit that referenced this pull request Jul 28, 2020
@jeherve
Changelog: add #16568
c90df4f
jeherve added a commit that referenced this pull request Nov 26, 2020
@jeherve
WPCOM API: update option names in request format
d0a2840 
I had forgotten to do it in #16568. We must update this as well so the new options are considered valid for update.
@jeherve jeherve mentioned this pull request Nov 26, 2020
Merged
jeherve added a commit that referenced this pull request Nov 26, 2020
@jeherve
WPCOM API: update option names in request format (#17910)
fa5d085 
I had forgotten to do it in #16568. We must update this as well so the new options are considered valid for update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdbitz mdbitz mdbitz approved these changes

Assignees

@jeherve jeherve

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] WPCOM API [Pri] Normal Touches WP.com Files

Projects

None yet

Milestone

8.8

Development

Successfully merging this pull request may close these issues.

4 participants

@jeherve @matticbot @jetpackbot @mdbitz