Skip to content

WPCOM API: update option names in request format#17910

Merged
jeherve merged 1 commit into
masterfrom
update/api-settings-request-format-options
Nov 26, 2020
Merged

WPCOM API: update option names in request format#17910
jeherve merged 1 commit into
masterfrom
update/api-settings-request-format-options

Conversation

@jeherve

@jeherve jeherve commented Nov 26, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Changes proposed in this Pull Request:

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

screenshot 2020-11-26 at 19 31 26

Proposed changelog entry for your changes:

  • N/A

@jeherve
WPCOM API: update option names in request format
d0a2840 
I had forgotten to do it in #16568. We must update this as well so the new options are considered valid for update.
@jeherve jeherve added Bug When a feature is broken and / or not performing as intended [Feature] WPCOM API [Status] Needs Review This PR is ready for review. [Pri] Normal labels Nov 26, 2020
@jeherve jeherve added this to the 9.3 milestone Nov 26, 2020
@jeherve jeherve self-assigned this Nov 26, 2020
@matticbot

matticbot commented Nov 26, 2020

Copy link
Copy Markdown
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D53387-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jeherve

jeherve commented Nov 26, 2020

Copy link
Copy Markdown
Member Author

r217406-wpcom

fgiannar
fgiannar approved these changes Nov 26, 2020
View reviewed changes

@fgiannar fgiannar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works well in all endpoint versions! Thanks for the fix!

@fgiannar fgiannar added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Nov 26, 2020
@jeherve jeherve merged commit fa5d085 into master Nov 26, 2020
@jeherve jeherve deleted the update/api-settings-request-format-options branch November 26, 2020 19:30
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgiannar fgiannar fgiannar approved these changes

Assignees

@jeherve jeherve

Labels

Bug When a feature is broken and / or not performing as intended [Feature] WPCOM API [Pri] Normal [Status] Tested on WP.com Touches WP.com Files

Projects

None yet

Milestone

9.3

Development

Successfully merging this pull request may close these issues.

3 participants

@jeherve @matticbot @fgiannar