Skip to content

Various: Update use of whitelist/blacklist#16109

Merged
kraftbj merged 6 commits into
masterfrom
remove/blacklist/part-2
Jun 10, 2020
Merged

Various: Update use of whitelist/blacklist#16109
kraftbj merged 6 commits into
masterfrom
remove/blacklist/part-2

Conversation

@kraftbj

@kraftbj kraftbj commented Jun 9, 2020

Copy link
Copy Markdown
Contributor

Supports #16099

Changes proposed in this Pull Request:

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • pb6Nl-duS-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Confirm dashboard builds.
  • Able to add an IP address to the Protect always allowed IP list via the dashboard.

Proposed changelog entry for your changes:

  • Would be covered by the other PR.

kraftbj added 4 commits June 8, 2020 17:30
@kraftbj
Update usages in 3rd-party
1481026
@kraftbj
Remove references within the _inc directory.
27c328d 
When syncing to WordPress.com, need to do a multistep move of the mapbox-blacklist library.
Also, leaving API endpoints alone for now.
@kraftbj
Update some package references
6551d6a
@kraftbj
Update modules, except for Protect and Mailchimp shortcode
fc618d6
@kraftbj kraftbj added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Forms [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Feature] Theme Tools [Status] Needs Review This PR is ready for review. Admin Page React-powered dashboard under the Jetpack menu [Pri] Normal [Feature] Calypsoify labels Jun 9, 2020
@kraftbj kraftbj requested review from a team and georgestephanis as code owners June 9, 2020 15:53
@kraftbj kraftbj self-assigned this Jun 9, 2020
@matticbot

matticbot commented Jun 9, 2020

Copy link
Copy Markdown
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello kraftbj! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D44654-code before merging this PR. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions Bot added the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Jun 9, 2020
@kraftbj kraftbj changed the title Remove/blacklist/part 2 Various: Update use of whitelist/blacklist Jun 9, 2020
@kraftbj kraftbj mentioned this pull request Jun 9, 2020
Closed
@jetpackbot

jetpackbot commented Jun 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16109

Scheduled Jetpack release: July 7, 2020.
Scheduled code freeze: June 30, 2020

Generated by 🚫 dangerJS against 15620ae

@jeherve jeherve added this to the 8.7 milestone Jun 9, 2020
@kraftbj kraftbj removed the [Status] Needs Review This PR is ready for review. label Jun 9, 2020
jeherve
jeherve requested changes Jun 9, 2020
View reviewed changes
Comment thread _inc/lib/class-jetpack-mapbox-helper.php
@kraftbj kraftbj force-pushed the remove/blacklist/part-2 branch from 671874a to 15620ae Compare June 9, 2020 19:16
@kraftbj kraftbj added the [Status] Needs Review This PR is ready for review. label Jun 9, 2020
@kraftbj kraftbj requested a review from jeherve June 9, 2020 20:04
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jun 10, 2020
@kraftbj kraftbj merged commit d37c4ec into master Jun 10, 2020
@kraftbj kraftbj deleted the remove/blacklist/part-2 branch June 10, 2020 21:49
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jun 10, 2020
@kraftbj

kraftbj commented Jun 10, 2020

Copy link
Copy Markdown
Contributor Author

r208839-wpcom and removed the old mapbox-blacklist file in r208841-wpcom

@kraftbj kraftbj mentioned this pull request Jun 15, 2020
Open
7 tasks
@jeherve jeherve removed the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Jul 29, 2020
nicokaiser added a commit to nicokaiser/lazy-images-without-jetpack that referenced this pull request Aug 8, 2020
@nicokaiser
backport: Various: Update use of whitelist/blacklist (Automattic/jetp…
46ce521 
…ack#16109)
@ockham ockham mentioned this pull request Nov 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes
@georgestephanis georgestephanis Awaiting requested review from georgestephanis

Assignees

@kraftbj kraftbj

Labels

Admin Page React-powered dashboard under the Jetpack menu Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Calypsoify [Feature] Forms [Feature] Theme Tools [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Pri] Normal Touches WP.com Files

Projects

None yet

Milestone

8.7

Development

Successfully merging this pull request may close these issues.

4 participants

@kraftbj @matticbot @jetpackbot @jeherve