Skip to content

Remove whitelist/blacklist from files in the Jetpack root directory#16100

Merged
kraftbj merged 2 commits into
masterfrom
remove/blacklist/root
Jun 9, 2020
Merged

Remove whitelist/blacklist from files in the Jetpack root directory#16100
kraftbj merged 2 commits into
masterfrom
remove/blacklist/root

Conversation

@kraftbj

@kraftbj kraftbj commented Jun 8, 2020

Copy link
Copy Markdown
Contributor

Supports #16099

Changes proposed in this Pull Request:

  • Update Jetpack CLI, Gutenberg class, and the main Jetpack class to remove most references to whitelist/blacklist.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • pb6Nl-duS-p2

Does this pull request change what data or activity we track or use?

  • No.

Testing instructions:

  • Test jetpack protect allow function. It should function the same as the pre-existing whitelist function. whitelist will still work in case there are partners who have scripted this CLI command in their systems, but not advertised.

Proposed changelog entry for your changes:

  • Removed instances of "whitelist" and "blacklist" from the Jetpack codebase.

@kraftbj kraftbj added Enhancement Changes to an existing feature — removing, adding, or changing parts of it General [Status] Needs Review This PR is ready for review. [Feature] Jetpack CLI [Pri] Normal [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Jun 8, 2020
@kraftbj kraftbj requested a review from a team as a code owner June 8, 2020 21:39
@kraftbj kraftbj self-assigned this Jun 8, 2020
@matticbot

Copy link
Copy Markdown
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello kraftbj! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D44599-code before merging this PR. Thank you!
This revision will be updated with each commit to this PR

@jetpackbot

jetpackbot commented Jun 8, 2020

Copy link
Copy Markdown
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16100

Scheduled Jetpack release: July 7, 2020.
Scheduled code freeze: June 30, 2020

Generated by 🚫 dangerJS against 941dff3

@jeherve jeherve added this to the 8.7 milestone Jun 9, 2020
Comment thread class.jetpack-cli.php Outdated
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! [Feature] Protect Also known as Brute Force Attack Protection and removed [Status] Needs Review This PR is ready for review. labels Jun 9, 2020
@kraftbj kraftbj merged commit 88bed90 into master Jun 9, 2020
@kraftbj kraftbj deleted the remove/blacklist/root branch June 9, 2020 20:09
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jun 9, 2020
@kraftbj

kraftbj commented Jun 9, 2020

Copy link
Copy Markdown
Contributor Author

r208741-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Jetpack CLI [Feature] Protect Also known as Brute Force Attack Protection [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack General [Pri] Normal Touches WP.com Files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants