Instant Search: Add caching to the api requests#13714
Merged
gibrown merged 3 commits intoinstant-search-masterfrom Oct 10, 2019
Merged
Instant Search: Add caching to the api requests#13714gibrown merged 3 commits intoinstant-search-masterfrom
gibrown merged 3 commits intoinstant-search-masterfrom
Conversation
jsnmoon
suggested changes
Oct 10, 2019
Contributor
jsnmoon
left a comment
There was a problem hiding this comment.
Changes look reasonable, but I think you might have nuked the yarn.lock file; let me see if I can fix that up.
Contributor
|
Caution: This PR has changes that must be merged to WordPress.com |
jsnmoon
approved these changes
Oct 10, 2019
jsnmoon
added a commit
that referenced
this pull request
Oct 23, 2019
* Implement minimal search results and spelling correction (#13365) * Add filtering display (#13371) * Fix search result display bugs and make improvements (#13393) * Add rudimentary support for filtering on post types (#13430) * Add support for filtering on categories and tags (#13505) * Add instant search sorting based on the URL (#13377) * Add support for filtering on dates (#13545) * Add custom taxonomy filtering (#13605) * add sort widget (#13614) * fix many theme incompatibilities (#13602) * Add infinite scrolling (#13684) * Add caching to the api requests (#13714) * Clean up some design bugs/issues (#13721) * Fix labels for post types when we have them. (#13750) * Add localization and formatting of all dates (#13748) * search from any page on the site (#13713) * Hook up default options (inc. sort) (#13742) * Add TrainTracks analytics (#13730) * Create PostTypeIcon component (#13790) * Upgrade to Preact 10 (#13794) * Add comments component (#13797) * Address review feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a simple 5 minute cache to start out. I was noticing that with starting and stopping filtering on other pages how slow and distracting it can feel to have to do that extra search request even though you just did the same search. Added some comments on some other cases to improve, but decided to try going simple.
bundle size before: 267902 Oct 10 17:54 jp-search.bundle.js
bundle size after: 305240 Oct 10 19:23 jp-search.bundle.js
Testing instructions: