Skip to content

Instant Search: add sort widget#13614

Merged
bluefuton merged 10 commits intoinstant-search-masterfrom
add/instant-search-sorting-ui
Oct 3, 2019
Merged

Instant Search: add sort widget#13614
bluefuton merged 10 commits intoinstant-search-masterfrom
add/instant-search-sorting-ui

Conversation

@bluefuton
Copy link
Copy Markdown
Contributor

Changes proposed in this Pull Request:

This enables sorting of search results from Jetpack Instant Search.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Yes, this adds a sorting UI to Jetpack Instant Search.

Testing instructions:

Add define( "JETPACK_SEARCH_PROTOTYPE", true ); to your wp-config.php.
Ensure that your site has the Jetpack Pro plan and has Jetpack Search enabled.
Add a Jetpack Search widget to the Search page sidebar.
Enter a query into a search widget. Alternatively, navigate to a search page like /?s=privacy.
Ensure that you can use the sort dropdown to change sort order.

Proposed changelog entry for your changes:

Not required.

@bluefuton bluefuton force-pushed the add/instant-search-sorting-ui branch from 4e5652b to 5541f7c Compare October 2, 2019 22:14
@bluefuton
Copy link
Copy Markdown
Contributor Author

bluefuton commented Oct 2, 2019

Todo:

  • add correct sort options
  • enable sorting based on current option

This PR does not use the user-specified default sort - we'll add in a followup PR.

@bluefuton bluefuton marked this pull request as ready for review October 3, 2019 01:56
@bluefuton bluefuton requested review from a team, gibrown and jsnmoon October 3, 2019 01:56
@bluefuton bluefuton added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Oct 3, 2019
Copy link
Copy Markdown
Member

@gibrown gibrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM. Minor suggestion.

Co-Authored-By: Greg Ichneumon Brown <greg@automattic.com>
Copy link
Copy Markdown
Contributor

@jsnmoon jsnmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bluefuton bluefuton merged commit 90716e6 into instant-search-master Oct 3, 2019
@bluefuton bluefuton deleted the add/instant-search-sorting-ui branch October 3, 2019 22:02
@matticbot matticbot removed the [Status] Needs Review This PR is ready for review. label Oct 3, 2019
jsnmoon added a commit that referenced this pull request Oct 23, 2019
* Implement minimal search results and spelling correction (#13365)
* Add filtering display (#13371)
* Fix search result display bugs and make improvements (#13393)
* Add rudimentary support for filtering on post types (#13430)
* Add support for filtering on categories and tags (#13505)
* Add instant search sorting based on the URL (#13377)
* Add support for filtering on dates (#13545)
* Add custom taxonomy filtering (#13605)
* add sort widget (#13614)
* fix many theme incompatibilities (#13602)
* Add infinite scrolling (#13684)
* Add caching to the api requests (#13714)
* Clean up some design bugs/issues (#13721)
* Fix labels for post types when we have them. (#13750)
* Add localization and formatting of all dates (#13748)
* search from any page on the site (#13713)
* Hook up default options (inc. sort) (#13742)
* Add TrainTracks analytics (#13730)
* Create PostTypeIcon component (#13790)
* Upgrade to Preact 10 (#13794)
* Add comments component (#13797)
* Address review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Search For all things related to Search New Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants