Sync: Add new WP Cli Lets us set disable and enable and reset jetpack sync queues.#12015
Sync: Add new WP Cli Lets us set disable and enable and reset jetpack sync queues.#12015
Conversation
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: April 29, 2019. |
kraftbj
left a comment
There was a problem hiding this comment.
very minor things, reads well.
kraftbj
left a comment
There was a problem hiding this comment.
I love the extra details when you're on a staging/development/etc site.
… disable jetpack sync not when we enable it
|
This PR contains many translatable strings with variables that don't have a translators comment explaining them. Could we use PHPCS on Jetpack to remind people to add those comments for placeholders? |
We have started adding more and more files to a pre-commit hook that won't let you commit changes if there are phpcs warnings in a file: Unfortunately, we can't just enable it for all files at once or it would make it very difficult to commit changes to most files in Jetpack today, so that's something that will take time. Until then, we recommend that everyone install those tools in their editor directly (see our docs here), but that's sometimes not enough, as you've found out. @enejb Do you think you could fix this in a new PR once #12081 is merged? |
|
There are tools to limit the scope so that you are not blamed for pre-phpcs code: https://github.com/xwp/wp-dev-lib/blob/master/readme.md#limiting-scope-of-checks |
This PR make will make it easier to disable, enable, reset jetpack sync and also show the sync settings.
Changes proposed in this Pull Request:
Testing instructions:
In an environment where wp cli is enabled run the following commands
wp jetpack sync settings
wp jetpack sync enable
wp jetpack sync disable
wp jetpack sync reset --queue=full
wp jetpack sync reset --queue=regular
wp jetpack sync reset
Proposed changelog entry for your changes: