Skip to content

fix: restore golangci-lint to v2.11.3 (broken by replace_all in #425)#427

Merged
Aureliolo merged 1 commit intomainfrom
fix/golangci-lint-version
Mar 15, 2026
Merged

fix: restore golangci-lint to v2.11.3 (broken by replace_all in #425)#427
Aureliolo merged 1 commit intomainfrom
fix/golangci-lint-version

Conversation

@Aureliolo
Copy link
Copy Markdown
Owner

@Aureliolo Aureliolo commented Mar 15, 2026

Summary

  • Restore golangci-lint version from v2.14.3 back to v2.11.3 (which is the latest release of golangci-lint)
  • PR fix: upgrade goreleaser to v2.14.3 (v2.11.3 never existed) #425 used replace_all on the string v2.11.3 which accidentally changed both the goreleaser version (intended) AND the golangci-lint version (unintended)
  • golangci-lint v2.14.3 doesn't exist — the latest is v2.11.3
  • This broke the CLI Lint job on the v0.2.1 tag release

Test plan

  • Verify CLI Lint job passes on this PR
  • After merge, re-trigger CLI release for the latest tag

@Aureliolo
fix: restore golangci-lint to v2.11.3 (broken by replace_all in #425)
76fff4a 
The goreleaser version fix in #425 used replace_all on "v2.11.3" which
also changed the golangci-lint version. golangci-lint v2.14.3 doesn't
exist — v2.11.3 is the latest. Restore it.
Copilot AI review requested due to automatic review settings March 15, 2026 00:59
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Mar 15, 2026

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 15, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@Aureliolo Aureliolo merged commit 8ba9375 into main Mar 15, 2026
32 of 33 checks passed
@Aureliolo Aureliolo deleted the fix/golangci-lint-version branch March 15, 2026 00:59
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 15, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0d5ab914-638b-42cf-9988-13c272b3eed2

📥 Commits

Reviewing files that changed from the base of the PR and between e4dfbea and 76fff4a.

📒 Files selected for processing (1)
  • .github/workflows/cli.yml
📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated CI/CD tooling version for code linting processes.

Walkthrough

A GitHub Actions workflow configuration file was updated to change the golangci-lint version from v2.14.3 to v2.11.3 in the CLI lint job.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/cli.yml		 Downgraded golangci-lint version from v2.14.3 to v2.11.3 in the CLI lint job.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/golangci-lint-version
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/golangci-lint-version
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@Aureliolo Aureliolo mentioned this pull request Mar 15, 2026
Merged
@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Mar 15, 2026

Greptile Summary

This PR is a targeted hotfix that restores the golangci-lint version pin in .github/workflows/cli.yml to v2.11.3 after it was accidentally bumped to the non-existent v2.14.3 by a replace_all operation in PR #425.

  • The root cause is clear and well-documented: PR fix: upgrade goreleaser to v2.14.3 (v2.11.3 never existed) #425 used replace_all on v2.11.3 → v2.14.3 to update GoReleaser, which also silently changed the unrelated golangci-lint version in the same file.
  • The GoReleaser version: v2.14.3 at line 280 is intentionally left unchanged, confirming the two version pins are now correctly decoupled.
  • The fix is minimal, correct, and has no side effects on any other workflow step.

Confidence Score: 5/5

  • This PR is safe to merge — it corrects a broken CI configuration with a single, well-understood version revert.
  • The change is a one-line revert of an accidental version bump. The root cause is clearly identified, the GoReleaser version at line 280 is correctly preserved at v2.14.3, and no other logic is touched. No new risks are introduced.
  • No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/cli.yml Single-line fix restoring golangci-lint version from the non-existent v2.14.3 back to v2.11.3; the GoReleaser step correctly retains v2.14.3 at line 280, confirming the two tool versions are now properly decoupled.

Last reviewed commit: 76fff4a

Aureliolo added a commit that referenced this pull request Mar 15, 2026
@Aureliolo
chore(main): release 0.2.2 (#428)
e69263a 
🤖 I have created a release *beep* *boop*
---


##
[0.2.2](v0.2.1...v0.2.2)
(2026-03-15)


### Bug Fixes

* restore golangci-lint to v2.11.3 (broken by replace_all in
[#425](#425))
([#427](#427))
([8ba9375](8ba9375))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Copilot AI reviewed Mar 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores the CLI workflow’s golangci-lint binary version to a valid release after PR #425 unintentionally changed it during a bulk replace, which broke the CLI lint job for tag builds/releases.

Changes:

  • Downgrade golangci-lint binary version in the CLI workflow from v2.14.3 (non-existent) back to v2.11.3.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

This was referenced Mar 15, 2026
Merged
Closed
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Aureliolo