fix: upgrade goreleaser to v2.14.3 (v2.11.3 never existed)#425
fix: upgrade goreleaser to v2.14.3 (v2.11.3 never existed)#425
Conversation
v2.11.3 was a typo — goreleaser only released v2.11.0, v2.11.1, v2.11.2. This caused the v0.2.0 CLI release to fail with a 404 when downloading the goreleaser binary. Upgrade to v2.14.3 (latest stable).
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughUpdates GitHub Actions tool versions in the CLI workflow file. The golangci-lint-action is bumped from v2.11.3 to v2.14.3, and goreleaser-action is bumped from v2.11.3 to v2.14.3. No workflow behavior or logic is modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
📝 Coding Plan
Comment |
Greptile SummaryThis PR fixes a legitimate GoReleaser version typo (
Confidence Score: 3/5
Important Files Changed
Prompt To Fix All With AIThis is a comment left during a code review.
Path: .github/workflows/cli.yml
Line: 69
Comment:
**Undocumented golangci-lint version bump**
This line changes the `golangci-lint` binary version from `v2.11.3` to `v2.14.3`, but the PR description only discusses the GoReleaser version fix. These are two entirely separate tools with independent release histories — the fact that GoReleaser never released `v2.11.3` does not imply the same about `golangci-lint`.
A few concerns here:
1. **If `golangci-lint v2.11.3` existed and was working**, this is a silent upgrade to `v2.14.3`. A newer major version of golangci-lint can introduce new or stricter lint rules that break the `cli-lint` job on code that previously passed.
2. **If `golangci-lint v2.14.3` does not exist**, the `cli-lint` job will fail with a 404 — the same failure mode this PR is trying to fix for GoReleaser.
Please verify:
- That `golangci-lint v2.14.3` exists in the [golangci-lint releases](https://github.com/golangci/golangci-lint/releases).
- That the lint job passes locally (or via CI) with this version before merging.
If the intent is just to fix the GoReleaser typo, this line should be reverted back to `v2.11.3` (or whatever the last known-good `golangci-lint` version was) to keep this PR scoped.
How can I resolve this? If you propose a fix, please make it concise.Last reviewed commit: 55fa36c |
| uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0 | ||
| with: | ||
| version: v2.11.3 | ||
| version: v2.14.3 |
There was a problem hiding this comment.
Undocumented golangci-lint version bump
This line changes the golangci-lint binary version from v2.11.3 to v2.14.3, but the PR description only discusses the GoReleaser version fix. These are two entirely separate tools with independent release histories — the fact that GoReleaser never released v2.11.3 does not imply the same about golangci-lint.
A few concerns here:
- If
golangci-lint v2.11.3existed and was working, this is a silent upgrade tov2.14.3. A newer major version of golangci-lint can introduce new or stricter lint rules that break thecli-lintjob on code that previously passed. - If
golangci-lint v2.14.3does not exist, thecli-lintjob will fail with a 404 — the same failure mode this PR is trying to fix for GoReleaser.
Please verify:
- That
golangci-lint v2.14.3exists in the golangci-lint releases. - That the lint job passes locally (or via CI) with this version before merging.
If the intent is just to fix the GoReleaser typo, this line should be reverted back to v2.11.3 (or whatever the last known-good golangci-lint version was) to keep this PR scoped.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/cli.yml
Line: 69
Comment:
**Undocumented golangci-lint version bump**
This line changes the `golangci-lint` binary version from `v2.11.3` to `v2.14.3`, but the PR description only discusses the GoReleaser version fix. These are two entirely separate tools with independent release histories — the fact that GoReleaser never released `v2.11.3` does not imply the same about `golangci-lint`.
A few concerns here:
1. **If `golangci-lint v2.11.3` existed and was working**, this is a silent upgrade to `v2.14.3`. A newer major version of golangci-lint can introduce new or stricter lint rules that break the `cli-lint` job on code that previously passed.
2. **If `golangci-lint v2.14.3` does not exist**, the `cli-lint` job will fail with a 404 — the same failure mode this PR is trying to fix for GoReleaser.
Please verify:
- That `golangci-lint v2.14.3` exists in the [golangci-lint releases](https://github.com/golangci/golangci-lint/releases).
- That the lint job passes locally (or via CI) with this version before merging.
If the intent is just to fix the GoReleaser typo, this line should be reverted back to `v2.11.3` (or whatever the last known-good `golangci-lint` version was) to keep this PR scoped.
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
Pull request overview
Fixes the CLI release workflow by updating the pinned GoReleaser binary version to a real, current release so tag-triggered CLI releases don’t fail when downloading the tool.
Changes:
- Update GoReleaser binary version input from
v2.11.3tov2.14.3for the CLI release job. - Also updates a
versionpin in the CLI lint job (currently appears to be conflated with the GoReleaser version).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0 | ||
| with: | ||
| version: v2.11.3 | ||
| version: v2.14.3 |
🤖 I have created a release *beep* *boop* --- ## [0.2.1](v0.2.0...v0.2.1) (2026-03-15) ### Bug Fixes * upgrade goreleaser to v2.14.3 (v2.11.3 never existed) ([#425](#425)) ([df6650d](df6650d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
The goreleaser version fix in #425 used replace_all on "v2.11.3" which also changed the golangci-lint version. golangci-lint v2.14.3 doesn't exist — v2.11.3 is the latest. Restore it.
…#427) ## Summary - Restore golangci-lint version from `v2.14.3` back to `v2.11.3` (which is the latest release of golangci-lint) - PR #425 used `replace_all` on the string `v2.11.3` which accidentally changed both the goreleaser version (intended) AND the golangci-lint version (unintended) - `golangci-lint v2.14.3` doesn't exist — the latest is `v2.11.3` - This broke the CLI Lint job on the `v0.2.1` tag release ## Test plan - [ ] Verify CLI Lint job passes on this PR - [ ] After merge, re-trigger CLI release for the latest tag
🤖 I have created a release *beep* *boop* --- ## [0.2.2](v0.2.1...v0.2.2) (2026-03-15) ### Bug Fixes * restore golangci-lint to v2.11.3 (broken by replace_all in [#425](#425)) ([#427](#427)) ([8ba9375](8ba9375)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Summary
v2.11.3tov2.14.3(latest stable)v2.11.3was a typo introduced when the CLI was first added — goreleaser only released v2.11.0, v2.11.1, v2.11.2v0.2.0CLI release to fail with a 404 when the goreleaser-action tried to download the binaryContext
The bug was latent because the CLI release job only triggers on
v*tags, andv0.2.0was the first release since the CLI was added. Dependabot updates the action SHA (goreleaser/goreleaser-action@SHA) but not theversioninput parameter — that's an opaque string referencing the goreleaser binary from a different repo.Test plan
v0.2.0tag to re-trigger the CLI release workflow