Skip to content

fix: upgrade goreleaser to v2.14.3 (v2.11.3 never existed)#425

Merged
Aureliolo merged 1 commit intomainfrom
fix/goreleaser-version
Mar 15, 2026
Merged

fix: upgrade goreleaser to v2.14.3 (v2.11.3 never existed)#425
Aureliolo merged 1 commit intomainfrom
fix/goreleaser-version

Conversation

@Aureliolo
Copy link
Copy Markdown
Owner

Summary

  • Upgrade GoReleaser binary version from v2.11.3 to v2.14.3 (latest stable)
  • v2.11.3 was a typo introduced when the CLI was first added — goreleaser only released v2.11.0, v2.11.1, v2.11.2
  • This caused the v0.2.0 CLI release to fail with a 404 when the goreleaser-action tried to download the binary
  • Docker images and GitHub Release changelog were unaffected (separate workflows)

Context

The bug was latent because the CLI release job only triggers on v* tags, and v0.2.0 was the first release since the CLI was added. Dependabot updates the action SHA (goreleaser/goreleaser-action@SHA) but not the version input parameter — that's an opaque string referencing the goreleaser binary from a different repo.

Test plan

  • Merge this PR, then delete and recreate the v0.2.0 tag to re-trigger the CLI release workflow
  • Verify GoReleaser downloads successfully and builds CLI binaries
  • Verify provenance attestation and release notes are appended

v2.11.3 was a typo — goreleaser only released v2.11.0, v2.11.1, v2.11.2.
This caused the v0.2.0 CLI release to fail with a 404 when downloading
the goreleaser binary. Upgrade to v2.14.3 (latest stable).
Copilot AI review requested due to automatic review settings March 15, 2026 00:49
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@github-actions
Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 15, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d20b23f6-e5f6-4de3-b823-7e8a411207b7

📥 Commits

Reviewing files that changed from the base of the PR and between 4cfc38a and 55fa36c.

📒 Files selected for processing (1)
  • .github/workflows/cli.yml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated development and release tooling versions to maintain compatibility and performance.

Walkthrough

Updates GitHub Actions tool versions in the CLI workflow file. The golangci-lint-action is bumped from v2.11.3 to v2.14.3, and goreleaser-action is bumped from v2.11.3 to v2.14.3. No workflow behavior or logic is modified.

Changes

Cohort / File(s) Summary
GitHub Actions Version Updates
.github/workflows/cli.yml
Bumped golangci-lint-action and goreleaser-action versions from v2.11.3 to v2.14.3 respectively.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/goreleaser-version
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/goreleaser-version
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@Aureliolo Aureliolo merged commit df6650d into main Mar 15, 2026
34 of 35 checks passed
@Aureliolo Aureliolo deleted the fix/goreleaser-version branch March 15, 2026 00:50
@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Mar 15, 2026

Greptile Summary

This PR fixes a legitimate GoReleaser version typo (v2.11.3v2.14.3) that was causing the CLI release job to fail with a 404. However, the same version string was also changed for golangci-lint (a completely separate project), which is not mentioned in the PR description and introduces its own risk.

  • GoReleaser fix (line 280): Correct and well-explained — GoReleaser never released v2.11.3, and the CLI release job was failing as a result.
  • golangci-lint version bump (line 69): Undocumented side effect. golangci-lint and goreleaser have independent release histories. If golangci-lint v2.14.3 does not exist, the cli-lint job will fail with the same 404 error pattern. If it does exist but introduces stricter lint rules, it could break the lint job on otherwise valid code. This change should be explicitly verified and documented.

Confidence Score: 3/5

  • Safe to merge once the golangci-lint v2.14.3 version is confirmed to exist and the lint job is verified to pass.
  • The GoReleaser fix is correct and necessary. The concern is the unverified, undocumented change to the golangci-lint binary version — if that version doesn't exist or introduces breaking lint rules, it swaps one 404 failure for another, or silently breaks the lint gate.
  • .github/workflows/cli.yml line 69 — confirm golangci-lint v2.14.3 is a valid release before merging.

Important Files Changed

Filename Overview
.github/workflows/cli.yml Bumps both GoReleaser (line 280) and golangci-lint (line 69) binary versions from v2.11.3 to v2.14.3; the GoReleaser fix is well-motivated, but the golangci-lint version change is undocumented and unverified — if v2.14.3 doesn't exist for golangci-lint, the lint job will 404.
Prompt To Fix All With AI
This is a comment left during a code review.
Path: .github/workflows/cli.yml
Line: 69

Comment:
**Undocumented golangci-lint version bump**

This line changes the `golangci-lint` binary version from `v2.11.3` to `v2.14.3`, but the PR description only discusses the GoReleaser version fix. These are two entirely separate tools with independent release histories — the fact that GoReleaser never released `v2.11.3` does not imply the same about `golangci-lint`.

A few concerns here:

1. **If `golangci-lint v2.11.3` existed and was working**, this is a silent upgrade to `v2.14.3`. A newer major version of golangci-lint can introduce new or stricter lint rules that break the `cli-lint` job on code that previously passed.
2. **If `golangci-lint v2.14.3` does not exist**, the `cli-lint` job will fail with a 404 — the same failure mode this PR is trying to fix for GoReleaser.

Please verify:
- That `golangci-lint v2.14.3` exists in the [golangci-lint releases](https://github.com/golangci/golangci-lint/releases).
- That the lint job passes locally (or via CI) with this version before merging.

If the intent is just to fix the GoReleaser typo, this line should be reverted back to `v2.11.3` (or whatever the last known-good `golangci-lint` version was) to keep this PR scoped.

How can I resolve this? If you propose a fix, please make it concise.

Last reviewed commit: 55fa36c

uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0
with:
version: v2.11.3
version: v2.14.3
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undocumented golangci-lint version bump

This line changes the golangci-lint binary version from v2.11.3 to v2.14.3, but the PR description only discusses the GoReleaser version fix. These are two entirely separate tools with independent release histories — the fact that GoReleaser never released v2.11.3 does not imply the same about golangci-lint.

A few concerns here:

  1. If golangci-lint v2.11.3 existed and was working, this is a silent upgrade to v2.14.3. A newer major version of golangci-lint can introduce new or stricter lint rules that break the cli-lint job on code that previously passed.
  2. If golangci-lint v2.14.3 does not exist, the cli-lint job will fail with a 404 — the same failure mode this PR is trying to fix for GoReleaser.

Please verify:

  • That golangci-lint v2.14.3 exists in the golangci-lint releases.
  • That the lint job passes locally (or via CI) with this version before merging.

If the intent is just to fix the GoReleaser typo, this line should be reverted back to v2.11.3 (or whatever the last known-good golangci-lint version was) to keep this PR scoped.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/cli.yml
Line: 69

Comment:
**Undocumented golangci-lint version bump**

This line changes the `golangci-lint` binary version from `v2.11.3` to `v2.14.3`, but the PR description only discusses the GoReleaser version fix. These are two entirely separate tools with independent release histories — the fact that GoReleaser never released `v2.11.3` does not imply the same about `golangci-lint`.

A few concerns here:

1. **If `golangci-lint v2.11.3` existed and was working**, this is a silent upgrade to `v2.14.3`. A newer major version of golangci-lint can introduce new or stricter lint rules that break the `cli-lint` job on code that previously passed.
2. **If `golangci-lint v2.14.3` does not exist**, the `cli-lint` job will fail with a 404 — the same failure mode this PR is trying to fix for GoReleaser.

Please verify:
- That `golangci-lint v2.14.3` exists in the [golangci-lint releases](https://github.com/golangci/golangci-lint/releases).
- That the lint job passes locally (or via CI) with this version before merging.

If the intent is just to fix the GoReleaser typo, this line should be reverted back to `v2.11.3` (or whatever the last known-good `golangci-lint` version was) to keep this PR scoped.

How can I resolve this? If you propose a fix, please make it concise.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the CLI release workflow by updating the pinned GoReleaser binary version to a real, current release so tag-triggered CLI releases don’t fail when downloading the tool.

Changes:

  • Update GoReleaser binary version input from v2.11.3 to v2.14.3 for the CLI release job.
  • Also updates a version pin in the CLI lint job (currently appears to be conflated with the GoReleaser version).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0
with:
version: v2.11.3
version: v2.14.3
Aureliolo added a commit that referenced this pull request Mar 15, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.2.1](v0.2.0...v0.2.1)
(2026-03-15)


### Bug Fixes

* upgrade goreleaser to v2.14.3 (v2.11.3 never existed)
([#425](#425))
([df6650d](df6650d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Aureliolo added a commit that referenced this pull request Mar 15, 2026
The goreleaser version fix in #425 used replace_all on "v2.11.3" which
also changed the golangci-lint version. golangci-lint v2.14.3 doesn't
exist — v2.11.3 is the latest. Restore it.
Aureliolo added a commit that referenced this pull request Mar 15, 2026
…#427)

## Summary

- Restore golangci-lint version from `v2.14.3` back to `v2.11.3` (which
is the latest release of golangci-lint)
- PR #425 used `replace_all` on the string `v2.11.3` which accidentally
changed both the goreleaser version (intended) AND the golangci-lint
version (unintended)
- `golangci-lint v2.14.3` doesn't exist — the latest is `v2.11.3`
- This broke the CLI Lint job on the `v0.2.1` tag release

## Test plan

- [ ] Verify CLI Lint job passes on this PR
- [ ] After merge, re-trigger CLI release for the latest tag
Aureliolo added a commit that referenced this pull request Mar 15, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.2.2](v0.2.1...v0.2.2)
(2026-03-15)


### Bug Fixes

* restore golangci-lint to v2.11.3 (broken by replace_all in
[#425](#425))
([#427](#427))
([8ba9375](8ba9375))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants