refactor(app): delete dead home page and redirect to default workspace (#603 PR1/3) by Astro-Han · Pull Request #651 · Astro-Han/pawwork

Astro-Han · 2026-05-15T13:42:13Z

Summary

Delete the dead packages/app/src/pages/home.tsx (139 lines: Logo + server picker + recent projects + empty state) and replace Route path="/" with a HomeRedirectRoute that resolves the first registered project at render time and <Navigate>s to /<base64>/session. Drop two orphan i18n keys (home.empty.title / home.empty.description); keep home.recentProjects — still used by dialog-select-directory.tsx:339.

4 files changed, +16 / -146.

Why

The / home page has been dead code for a while: Electron webContents persists the last URL, and the backend defaults the workspace to ~/PawWork (opencode/src/server/instance/middleware.ts:52,64). Every boot opens directly into the session route for the resolved path, bypassing /. Users only ever see the session-less landing rendered by NewSessionView — not this page.

W5 collapses the two homes into one surface. Slice 1 of 3 for #603 removes the dead one. PR2 will strip the skill-card shortcuts; PR3 will rewrite NewSessionView as the W5 hero.

Full design + 3-slice inventory: issue comment 4460021650.

Related Issue

Refs #603.

Human Review Status

Pending. A human should make the final merge decision after reviewing the diff and verification evidence below.

Review Focus

HomeRedirectRoute correctness: blank-div fallback covers the one-frame layout.projects.list() hydration window so users see no flash of old content if a stale URL or programmatic navigation hits /. <Navigate> only side-effects on mount.
list()[0] is the deterministic redirect target — no last-active persistence. On multi-project setups the redirect lands on whichever project sorts first. Acceptable per design comment 4460021650; future work could add last-active persistence.
Imports added to app.tsx: useLayout (already a sibling of LayoutProvider), base64Encode (already used by local.tsx, notification.tsx), createMemo + Show (already imported from solid-js).

Risk Notes

Low. The deleted file was already unreachable in normal launch flow. The new redirect protects against the edge case of a stale webContents URL pointing to / after a future refactor that breaks the persistence chain. home.recentProjects is preserved because dialog-select-directory.tsx:339 consumes it.

No platform-specific risk (macOS / Windows). No packaging / updater / signing / permissions changes. No new dependencies.

How To Verify

bun --cwd packages/app run typecheck: clean
bun --cwd packages/app run test:unit: 1078 pass / 0 fail (baseline matches)
bun --cwd packages/app run build: clean; the old HomeRoute lazy chunk is gone from the output
crosscheck on packages/app/src/app.tsx: 0 P0/P1 across both reviewers (only P2/P3 design suggestions about last-active persistence + a11y on the placeholder)

Electron manual check was skipped because PR1 has no visible UI change in the normal launch flow — users land directly on /<base64>/session via webContents URL persistence; the / redirect only fires if a stale URL or programmatic navigation hits root. Reviewer can verify locally: bun run dev:desktop, open devtools, run window.location.href = "/", observe redirect to /<base64>/session without flash.

Screenshots or Recordings

Not applicable — no visible UI change in the normal launch flow. The dead / page is removed; the only user-visible difference is "no flash of old home content if / is hit", which is invisible to most users.

Checklist

Summary by CodeRabbit

New Features
- Root route now automatically redirects to the most recent project session
- Added automatic fallback to backend project data when local cache is unavailable
Tests
- Updated e2e tests to verify new root route redirection behavior

The /pages/home.tsx page (139 lines: Logo, server picker, recent projects, empty state) was never reached: Electron webContents persists the last URL, and the backend defaults the workspace to ~/PawWork (opencode/src/server/instance/middleware.ts:52,64). Every boot opens directly into the session route for the resolved path, bypassing /. Replace Route path="/" with HomeRedirectRoute that resolves the first registered project at render time and <Navigate>s to /<base64>/session. The blank fallback covers the one-frame projects-list hydration window so users see no flash of old home content. Remove the two orphan i18n keys (home.empty.title / home.empty.description); home.recentProjects stays — still used by dialog-select-directory.tsx:339. Slice 1 of 3 for #603 (W5 home surface). PR2 will remove the skill-card shortcuts; PR3 will rewrite NewSessionView as the W5 hero. See issue comment 4460021650 for the full design + 3-slice inventory. Refs #603.

github-actions

Suggested priority: P2 (includes user-path files (packages/app/src/app.tsx, packages/app/src/i18n/en.ts, packages/app/src/i18n/zh.ts, packages/app/src/pages/home.tsx)).

P1/P0 are reserved for maintainer confirmation. Please relabel manually if this is a release blocker, security issue, data-loss risk, or updater/runtime failure.

coderabbitai · 2026-05-15T13:42:34Z

Warning

Rate limit exceeded

@Astro-Han has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 39 minutes and 26 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8c344786-2e99-4925-b938-211a014d8f3d

📥 Commits

Reviewing files that changed from the base of the PR and between 64e93c4 and ca5a2e8.

📒 Files selected for processing (2)

packages/app/e2e/app/root-redirect.spec.ts
packages/app/src/app.tsx

📝 Walkthrough

Walkthrough

Root landing path now redirects to the first available project's session route via a new HomeRedirectRoute. The Home page component and its empty-state translations were removed; i18n now uses a recent-projects label. E2E smoke tests and smoke-tagging were updated to cover the new root redirect behavior.

Changes

Home Route Redirect

Layer / File(s)	Summary
Root redirect route implementation `packages/app/src/app.tsx`	Adds `HomeRedirectRoute`, importing `useLayout`, `useGlobalSync`, and `base64Encode`; waits for the first project worktree and navigates to `/{base64Encode(worktree)}/session`. Replaces the root `/` route to render `HomeRedirectRoute`.
i18n strings for home section `packages/app/src/i18n/en.ts`, `packages/app/src/i18n/zh.ts`	Removes `home.empty.title` and `home.empty.description` entries and adds `home.recentProjects` label in English and Chinese dictionaries.
E2E tests and smoke-tagging `packages/app/e2e/app/home.spec.ts`, `packages/app/e2e/app/root-redirect.spec.ts`, `packages/opencode/test/config/e2e-smoke-tagging.test.ts`	Removes the old root empty-state smoke test from `home.spec.ts`, adds a new `root-redirect.spec.ts` that clears localStorage `projects` and asserts redirect to `/{slug}/session`, and updates `expectedSmokeTests` to include the new root-redirect smoke entry.

Sequence Diagram(s)

sequenceDiagram
  participant Browser as Browser
  participant Router as App Router
  participant HomeRedirect as HomeRedirectRoute
  participant Layout as LayoutContext (useLayout)
  participant GlobalSync as GlobalSync (useGlobalSync)
  participant Navigate as Navigate / SessionRoute
  Browser->>Router: navigate to /
  Router->>HomeRedirect: render HomeRedirectRoute
  HomeRedirect->>Layout: read projects.list()[0]
  alt layout has project
    Layout-->>HomeRedirect: project worktree
  else layout missing
    HomeRedirect->>GlobalSync: fallback read project[0]
    GlobalSync-->>HomeRedirect: project worktree
  end
  HomeRedirect->>Navigate: Navigate to /{base64Encode(worktree)}/session

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Astro-Han/pawwork#540: Changes Playwright root-route empty-state assertions that overlap with the removed home empty-state smoke test.

Suggested labels

enhancement, task

Poem

🐰
Home no longer waits for you,
First project hops into view,
Redirect quick, a tidy run,
Session open—work's begun!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: deleting the dead home page and adding a redirect route to the default workspace, including the issue reference and PR slice number.
Description check	✅ Passed	The description comprehensively covers all template sections: summary of changes, rationale, related issue, human review status, review focus areas, risk assessment, verification steps with results, and a completed checklist.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch claude/i603-pr1-route-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-05-15T13:45:44Z

Perf delta summary

Comparator: pass

Profile / Scenario	interaction median	interaction worst	long task max	tbt	frame gap p95	frame gap max	jank count	cls	status
default / homepage-cold	32 -> 32 (0)	64 -> 40 (-24)	86 -> 65 (-21)	36 -> 15 (-21)	16.8 -> 33.4 (+16.6)	150 -> 133.3 (-16.7)	4 -> 3 (-1)	0 -> 0 (0)	pass
default / long-session-input-lag	56 -> 40 (-16)	56 -> 56 (0)	0 -> 0 (0)	0 -> 0 (0)	16.7 -> 16.7 (0)	16.7 -> 16.8 (+0.1)	0 -> 0 (0)	0 -> 0 (0)	pass
default / session-streaming-long	48 -> 48 (0)	64 -> 64 (0)	114 -> 0 (-114)	64 -> 0 (-64)	16.8 -> 16.8 (0)	100 -> 33.3 (-66.7)	1 -> 0 (-1)	0 -> 0 (0)	pass
default / tool-call-expand	16 -> 16 (0)	16 -> 16 (0)	0 -> 0 (0)	0 -> 0 (0)	16.8 -> 16.7 (-0.1)	16.8 -> 16.7 (-0.1)	0 -> 0 (0)	0 -> 0 (0)	pass
default / tool-default-open-heavy-bash	24 -> 32 (+8)	32 -> 32 (0)	68 -> 66 (-2)	18 -> 16 (-2)	50 -> 50.1 (+0.1)	116.7 -> 116.7 (0)	3 -> 4 (+1)	0 -> 0 (0)	pass
default / terminal-side-panel-open	48 -> 48 (0)	80 -> 56 (-24)	0 -> 0 (0)	0 -> 0 (0)	33.3 -> 16.8 (-16.5)	33.3 -> 16.8 (-16.5)	0 -> 0 (0)	0 -> 0 (0)	pass
default / session-scroll-reading	32 -> 40 (+8)	64 -> 48 (-16)	0 -> 0 (0)	0 -> 0 (0)	16.7 -> 16.7 (0)	16.7 -> 16.7 (0)	0 -> 0 (0)	0.505 -> 0.505 (0)	warn: cls
low-end / session-scroll-reading-long	72 -> 48 (-24)	88 -> 56 (-32)	82 -> 97 (+15)	55 -> 74 (+19)	16.8 -> 16.8 (0)	216.7 -> 166.6 (-50.1)	5 -> 4 (-1)	0.016 -> 0.016 (0)	pass
low-end / session-timeline-recompute	120 -> 120 (0)	136 -> 128 (-8)	111 -> 109 (-2)	185 -> 185 (0)	100 -> 100 (0)	199.9 -> 183.3 (-16.6)	4 -> 3 (-1)	0.081 -> 0.081 (0)	pass
low-end / concurrent-shimmer-extreme	0 -> 0 (0)	0 -> 0 (0)	0 -> 0 (0)	0 -> 0 (0)	16.7 -> 16.8 (+0.1)	16.8 -> 16.8 (0)	0 -> 0 (0)	0 -> 0 (0)	pass

gemini-code-assist

Code Review

This pull request replaces the home page with a redirection mechanism that automatically routes users to the first available project's session. This change includes the removal of the Home component and its corresponding translation strings. A critical bug was identified in the new HomeRedirectRoute component where the child function of the Show component incorrectly treats its argument as an accessor, which will lead to a runtime TypeError in SolidJS.

The "root route renders the no-project empty state" smoke test asserted text and a button that this PR removes (home.empty.title / home.empty.description / the Open Project button on the dead / page). The empty-projects scenario the test mocked is impossible in real product because the backend ensures ~/PawWork exists at middleware.ts:64; the test was an artificial mock of UI that no longer exists. Other home.spec.ts cases (hero composer, starter cards, prompt-starts- session, single-row bar, model chip, server picker) are unchanged and still cover the live home surface. The sidebar "No projects open" state that this test also touched still has coverage elsewhere if needed; not in scope for this PR. Refs #603.

@smoke

Sync the e2e-smoke-tagging.test.ts expected inventory with the prior removal of the "@smoke root route renders the no-project empty state" title from home.spec.ts. The inventory test enforces an exact-match contract on the @smoke catalog, so removing a spec without updating this list fails unit-opencode CI.

@smoke

HomeRedirectRoute previously read only layout.projects.list(), which is the localStorage-persisted sidebar list of projects the user has opened in this client. On a clean install (empty localStorage) that list is [], so the route stayed on the hidden pending placeholder with no visible entry, even though the backend already registered ~/PawWork via middleware.ts mkdirSync. Add globalSync.project (the backend-pushed project catalogue) as a fallback so a fresh client redirects to /<slug>/session once the backend sync arrives, instead of stalling indefinitely. Cover the path with a new @smoke spec that opens a project, wipes the local server.projects map to mimic a clean client, navigates to /, and asserts the URL still lands on the project session route. Add the new title to the e2e-smoke-tagging inventory.

@smoke

The new @smoke spec asserted toHaveURL(/${project.slug}/session), which expected the redirect to land on the fixture's test directory. In practice globalSync.project[0] on CI is the PawWork default project (~/PawWork), not the test fixture's createTestProject directory, so the URL legitimately resolved to /<base64-of-PawWork>/session. Switch the assertion to a slug-agnostic /<base64>/session pattern. The contract this test guards is "root no longer stalls on the hidden pending placeholder when localStorage is empty", which the pattern match expresses without coupling to which backend project comes first.

globalStore.project is hydrated from the persisted projectCache before the boot fetch runs (global-sync.tsx initial state + bootstrap.ts slow phase). Reading sync.data.project[0] before sync.ready can therefore hand the redirect a stale entry that the backend no longer registers, sending the user to a directory that fails to load. Gate the backend fallback on sync.ready so the route keeps the hidden placeholder until the fresh project list arrives. Normal Electron boots restore the previous URL via webContents persistence and never reach /, so the added wait is invisible in practice and only protects clean installs and cache-cleared edge cases.

## Summary Refresh the home `<h1>` to the W5 welcome wording locked by the design preview ("今天我们做点什么？" / "What should we work on?") and tune the heading typography toward `--type-display`: medium weight, 28/130, and the documented zh-CJK letter-spacing rule (CJK 0, en tightest). Widen the heading-to-composer gap from `mt-12` to `mt-20` so the hero block breathes. Production layout, `WorkspaceChip` inside the composer, and every other home surface stay untouched. ## Why PR1 (#651) cleared the dead home page and PR2 (#657) stripped the skill-card pipeline. PR3 originally planned to rewrite `NewSessionView` as a W5 hero (meta-path button + branch chip + extracted `WorkspacePopover`). The maintainer manual-tested the experiment in Electron and decided the cwd signal reads cleaner where it already is (inside the composer), and that the home page should stay minimal. Rolled back to the smallest change that delivers the welcome copy + typography refresh on the existing layout. ## Related Issue Refs #603. Slice 3 of 3. ## Human Review Status Pending. A human should make the final merge decision after reviewing the final diff and verification evidence. ## Review Focus - `session-new-view.tsx` — `--type-display` is rendered with arbitrary Tailwind values (`text-[28px] font-medium leading-[1.3]` + `tracking-[var(--letter-spacing-tightest|normal)]`) because there is no `text-display` utility class yet. Introducing one would be a cross-package utility addition (would touch `packages/ui` and the error-page heading); kept out of scope and noted as a follow-up candidate. - i18n: `home.hero.title` replaces `session.new.title`. Both `parity.test.ts` and the `home.spec.ts` heading assertion are updated. `session.new.title` is removed in both locales — grep confirms no other consumer. - The opencode `@smoke` inventory in `packages/opencode/test/config/e2e-smoke-tagging.test.ts` is updated alphabetically to match the new home smoke title. ## Risk Notes None. No behavioral or platform-impacting change. No new schema, no migration, no IPC surface touched. ## How To Verify ```text packages/app typecheck (tsgo -b): clean packages/opencode typecheck (tsgo --noEmit): clean packages/app unit tests (bun test src/): 1103 pass / 0 fail / 2649 expect() packages/app E2E home.spec.ts (chromium): 6 pass / 10.0s packages/opencode e2e-smoke-tagging unit: 2 pass Electron `bun run dev:desktop` manual check: heading copy + medium-weight display tier + heading↔composer gap visible; WorkspaceChip remains inside composer; zh + en letter-spacing rules both render Crosscheck (Claude Opus + Codex): 0 P0 / 0 P1; one P2 (`tracking-[var(--letter-spacing-tightest)]` token swap) applied in-PR; other P2/P3 deferred (new utility class out of scope; pre-existing parity-test observation) ``` ## Screenshots or Recordings Manual screenshot to be attached after PR open — the visible change is the heading copy ("今天我们做点什么？" / "What should we work on?") plus the slightly heavier medium-weight 28/130 display heading and the wider heading-to-composer gap. The composer, workspace chip, and overall layout are byte-for-byte unchanged from production. ## Checklist - [x] Human review status is stated above as pending, approved, or not required - [x] I linked the related issue, or stated why there is no issue - [x] This PR has type, primary area, and priority labels, or I requested maintainer labeling - [x] I described the review focus and any meaningful risks - [x] I listed the relevant verification steps and the key result for each - [x] I did not introduce unrelated refactors, dependencies, generated files, or file changes beyond the stated scope - [x] I manually checked visible UI or copy changes when needed, with screenshots or recordings - [x] I considered macOS and Windows impact for platform, packaging, updater, signing, paths, shell, or permissions changes - [x] I called out docs, release notes, dependencies, permissions, credentials, deletion behavior, generated content, or local file changes when relevant - [x] I reviewed the final diff for unrelated changes and suspicious dependency changes - [x] I am targeting `dev`, and my PR title and commit messages use Conventional Commits in English

github-actions Bot added app Application behavior and product flows ui Design system and user interface labels May 15, 2026

github-actions Bot reviewed May 15, 2026

View reviewed changes

Astro-Han added tech-debt Supplemental cleanup, maintainability, architecture, test, or quality debt context P2 Medium priority labels May 15, 2026

gemini-code-assist Bot reviewed May 15, 2026

View reviewed changes

Comment thread packages/app/src/app.tsx Outdated

Astro-Han added 2 commits May 15, 2026 22:19

github-actions Bot added the harness Model harness, prompts, tool descriptions, and session mechanics label May 15, 2026

Astro-Han added 3 commits May 15, 2026 22:55

Astro-Han merged commit 4d8a5c9 into dev May 15, 2026
25 checks passed

Astro-Han deleted the claude/i603-pr1-route-cleanup branch May 15, 2026 15:32

coderabbitai Bot mentioned this pull request May 15, 2026

refactor(app): remove skill-card shortcuts and home-override pipeline (#603 PR2/3) #657

Merged

11 tasks

Astro-Han mentioned this pull request May 16, 2026

refactor(app): refresh home welcome heading (#603 PR3/3) #661

Merged

11 tasks

Astro-Han mentioned this pull request May 16, 2026

[Task] UI rewrite v2 Area C: home surface modular rollout #603

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(app): delete dead home page and redirect to default workspace (#603 PR1/3)#651

refactor(app): delete dead home page and redirect to default workspace (#603 PR1/3)#651
Astro-Han merged 6 commits into
devfrom
claude/i603-pr1-route-cleanup

Astro-Han commented May 15, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

github-actions Bot left a comment

Uh oh!

coderabbitai Bot commented May 15, 2026 •

edited

Loading

Rate limit exceeded

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented May 15, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Astro-Han commented May 15, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Related Issue

Human Review Status

Review Focus

Risk Notes

How To Verify

Screenshots or Recordings

Checklist

Summary by CodeRabbit

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf delta summary

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Astro-Han commented May 15, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 15, 2026 •

edited

Loading

github-actions Bot commented May 15, 2026 •

edited

Loading