test(app): cover root empty state by Astro-Han · Pull Request #540 · Astro-Han/pawwork

Astro-Han · 2026-05-11T05:29:35Z

Summary

Update the root route smoke test to cover the real no-project empty state instead of expecting seeded home entrypoints.

Why

#529 cleanup found that / without an opened project was not explicitly covered. The previous root smoke test expected the seeded session-new-home surface, so it did not lock the empty-state path users see before opening a project.

Related Issue

Refs #529.

Human Review Status

Pending. A human should make the final merge decision after reviewing the final diff and verification evidence.

Review Focus

Please verify the test now matches the intended root-route behavior: no session composer is rendered without a project, the main empty state is visible, the sidebar empty state is visible, and the Open project action opens the directory dialog.

Risk Notes

Test-only change. No product code, schema, dependency, platform, packaging, or permission changes.

How To Verify

Focused E2E: bun run test:e2e -- app/home.spec.ts --grep "root route" --workers=1 -> 1 passed
Typecheck: bun run typecheck -> passed
Diff check: git diff --check -> no whitespace errors

Screenshots or Recordings

Not required. This is a test-only PR with no visible product change.

Checklist

Summary by CodeRabbit

Tests
- Updated smoke test to verify empty state behavior when no projects are available, including messaging and dialog functionality.

coderabbitai · 2026-05-11T05:29:42Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b3d19bff-81b6-444c-b0cc-eeba4c93730e

📥 Commits

Reviewing files that changed from the base of the PR and between f941040 and 5cb049c.

📒 Files selected for processing (1)

packages/app/e2e/app/home.spec.ts

📝 Walkthrough

Walkthrough

The root-route Playwright test is refactored to mock backend API responses and seed localStorage state, then validate that the home component displays the no-project empty state with correct messaging, verifies the sidebar behavior, and confirms the "Open project" dialog interaction works as expected.

Changes

Home Empty State Test

Layer / File(s)	Summary
Empty State Behavior Test `packages/app/e2e/app/home.spec.ts`	Root-route smoke test mocks API responses for root and project list endpoints, seeds localStorage keys, and asserts home shows "No recent projects" and "Get started…" CTA plus "Open project" button. Verifies composer dock is absent, sidebar displays "No projects open" and "Open a project…" messaging, and "Open project" dialog appears on user action.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A test hops forth, mocking the way,
No projects found—an empty day,
Yet buttons click and dialogs glow,
The homepage dreams of projects to show! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: updating a test to cover the root empty state, which matches the primary objective of the PR.
Description check	✅ Passed	The description comprehensively follows the template with all required sections completed: Summary, Why, Related Issue, Human Review Status, Review Focus, Risk Notes, How To Verify, Screenshots, and Checklist all properly filled out.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/i529-root-route-empty-state

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist

Code Review

This pull request updates the E2E tests for the root route to verify the 'no-project' empty state, replacing the previous seeded home entrypoints. The changes include new assertions for empty state text and the 'Open project' button. Feedback suggests scoping the 'Open project' button locator to the sidebar to improve test robustness and avoid reliance on DOM order.

Astro-Han · 2026-05-11T05:38:57Z

Addressed Gemini review: the test no longer uses .last(). The Open project click is now scoped to the main landmark, which removes the DOM-order dependency; the assertion text is also bilingual to handle CI locale. Resolving the outdated thread.

Astro-Han · 2026-05-11T06:23:44Z

@coderabbitai review

coderabbitai · 2026-05-11T06:23:50Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@smoke

* fix(app): restore prompt input bottom radius * fix(opencode): sync @smoke inventory with home spec retitle from #540

Astro-Han added bug Something isn't working app Application behavior and product flows P3 Low priority task Narrow execution, audit, spike, migration, tracking, or upstream follow-up work labels May 11, 2026

gemini-code-assist Bot reviewed May 11, 2026

View reviewed changes

Comment thread packages/app/e2e/app/home.spec.ts Outdated

Astro-Han force-pushed the codex/i529-root-route-empty-state branch from e9ac3f6 to 9238474 Compare May 11, 2026 05:37

test(app): cover root empty state

5cb049c

Astro-Han force-pushed the codex/i529-root-route-empty-state branch from 9238474 to 5cb049c Compare May 11, 2026 05:53

Astro-Han merged commit 1e965b2 into dev May 11, 2026
22 checks passed

Astro-Han deleted the codex/i529-root-route-empty-state branch May 11, 2026 06:55

Astro-Han added a commit that referenced this pull request May 11, 2026

fix(opencode): sync @smoke inventory with home spec retitle from #540

aa03e0e

Astro-Han mentioned this pull request May 11, 2026

fix(app): restore prompt input bottom radius #542

Merged

11 tasks

Astro-Han added a commit that referenced this pull request May 11, 2026

fix(app): restore prompt input bottom radius (#542)

a09311c

* fix(app): restore prompt input bottom radius * fix(opencode): sync @smoke inventory with home spec retitle from #540

Astro-Han mentioned this pull request May 11, 2026

[Task] bootstrapDirectory > marks session status as error test fails on Windows runner (advisory) #546

Closed

coderabbitai Bot mentioned this pull request May 15, 2026

refactor(app): delete dead home page and redirect to default workspace (#603 PR1/3) #651

Merged

11 tasks

coderabbitai Bot mentioned this pull request Jun 5, 2026

feat(app): support direct-start sessions #1173

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(app): cover root empty state#540

test(app): cover root empty state#540
Astro-Han merged 1 commit into
devfrom
codex/i529-root-route-empty-state

Astro-Han commented May 11, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 11, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Astro-Han commented May 11, 2026

Uh oh!

Astro-Han commented May 11, 2026

Uh oh!

coderabbitai Bot commented May 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Astro-Han commented May 11, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Related Issue

Human Review Status

Review Focus

Risk Notes

How To Verify

Screenshots or Recordings

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Astro-Han commented May 11, 2026

Uh oh!

Astro-Han commented May 11, 2026

Uh oh!

coderabbitai Bot commented May 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Astro-Han commented May 11, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 11, 2026 •

edited

Loading