Skip to content

fix(app): restore prompt input bottom radius#542

Merged
Astro-Han merged 2 commits into
devfrom
fix/prompt-input-bottom-radius
May 11, 2026
Merged

fix(app): restore prompt input bottom radius#542
Astro-Han merged 2 commits into
devfrom
fix/prompt-input-bottom-radius

Conversation

@Astro-Han

@Astro-Han Astro-Han commented May 11, 2026

Copy link
Copy Markdown
Owner

Summary

Fix home prompt input bottom radius being clipped (task #17 regression). Adds overflow-hidden rounded-b-[var(--radius-lg)] to the inner chrome wrapper of PromptInput so the bottom corners are clipped again.

Also syncs the opencode @smoke inventory with the home spec retitle merged in #540, which was leaving CI red on dev.

Why

PR cf7126b (#524) changed the outer DockCard to overflow-visible! to restore popover visibility, which caused the inner gradient/background of the prompt input to no longer be clipped by the outer rounded corner, making the bottom edge appear flat. This PR adds overflow + bottom radius on the inner wrapper only, leaving the outer DockCard untouched so #524 popover visibility is preserved.

PR #540 retitled the root-route home smoke test after this branch was created, but the opencode smoke inventory on dev still referenced the old title. This PR syncs that expected title so the merge-state CI can pass.

Related Issue

task #17 / regression introduced in commit cf7126b; CI blocker introduced by PR #540 smoke-title retitle.

Human Review Status

Opus second-pass: pass
GPT-X engineering final review: pass (geometry check verified overflow:hidden and bottom-radius:14px via focused locator)
Human final merge decision: pending

Review Focus

Risk Notes

Low risk. The inner overflow-hidden does not affect popover rendering, which is governed by the outer DockCard overflow-visible!. The opencode change is a one-line test inventory sync for an already-merged smoke-title change.

How To Verify

prompt-slash-open E2E: 3 passed
Typecheck: passed
Diff check: no whitespace errors
Geometry check: GPT-X verified overflow:hidden and bottom radius 14px with focused locator
Smoke inventory: packages/opencode @smoke inventory matches dev's home.spec.ts after merge
Screenshot: uploaded in Slock thread #PawWork:fa978555 attachment d6a37675

Screenshots or Recordings

Screenshot uploaded in Slock thread #PawWork:fa978555 as attachment d6a37675 for visual confirmation.

Checklist

  • Human review status is stated above as pending, approved, or not required
  • I linked the related issue, or stated why there is no issue
  • This PR has type, primary area, and priority labels, or I requested maintainer labeling
  • I described the review focus and any meaningful risks
  • I listed the relevant verification steps and the key result for each
  • I did not introduce unrelated refactors, dependencies, generated files, or file changes beyond the stated scope
  • I manually checked visible UI or copy changes when needed, with screenshots or recordings
  • I considered macOS and Windows impact for platform, packaging, updater, signing, paths, shell, or permissions changes
  • I called out docs, release notes, dependencies, permissions, credentials, deletion behavior, generated content, or local file changes when relevant
  • I reviewed the final diff for unrelated changes and suspicious dependency changes
  • I am targeting dev, and my PR title and commit messages use Conventional Commits in English

@coderabbitai

coderabbitai Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@Astro-Han has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 3 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 825731f8-951c-4d1a-a049-a6e404a0efdd

📥 Commits

Reviewing files that changed from the base of the PR and between 1e965b2 and aa03e0e.

📒 Files selected for processing (2)
  • packages/app/src/components/prompt-input.tsx
  • packages/opencode/test/config/e2e-smoke-tagging.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/prompt-input-bottom-radius

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Astro-Han Astro-Han added bug Something isn't working app Application behavior and product flows P2 Medium priority task Narrow execution, audit, spike, migration, tracking, or upstream follow-up work labels May 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the PromptInput component by adding overflow-hidden and rounded-b-[var(--radius-lg)] CSS classes to a container div, likely to ensure proper rounding and clipping of the component's bottom border. I have no feedback to provide as there were no review comments.

@Astro-Han Astro-Han merged commit a09311c into dev May 11, 2026
22 checks passed
@Astro-Han Astro-Han deleted the fix/prompt-input-bottom-radius branch May 11, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app Application behavior and product flows bug Something isn't working P2 Medium priority task Narrow execution, audit, spike, migration, tracking, or upstream follow-up work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant