fix(app): restore prompt input bottom radius#542
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the PromptInput component by adding overflow-hidden and rounded-b-[var(--radius-lg)] CSS classes to a container div, likely to ensure proper rounding and clipping of the component's bottom border. I have no feedback to provide as there were no review comments.
Summary
Fix home prompt input bottom radius being clipped (task #17 regression). Adds
overflow-hidden rounded-b-[var(--radius-lg)]to the inner chrome wrapper of PromptInput so the bottom corners are clipped again.Also syncs the opencode
@smokeinventory with the home spec retitle merged in #540, which was leaving CI red ondev.Why
PR cf7126b (#524) changed the outer DockCard to
overflow-visible!to restore popover visibility, which caused the inner gradient/background of the prompt input to no longer be clipped by the outer rounded corner, making the bottom edge appear flat. This PR adds overflow + bottom radius on the inner wrapper only, leaving the outer DockCard untouched so #524 popover visibility is preserved.PR #540 retitled the root-route home smoke test after this branch was created, but the opencode smoke inventory on
devstill referenced the old title. This PR syncs that expected title so the merge-state CI can pass.Related Issue
task #17 / regression introduced in commit cf7126b; CI blocker introduced by PR #540 smoke-title retitle.
Human Review Status
Opus second-pass: pass
GPT-X engineering final review: pass (geometry check verified
overflow:hiddenandbottom-radius:14pxvia focused locator)Human final merge decision: pending
Review Focus
dev's home spec title after the test(app): cover root empty state #540 mergeRisk Notes
Low risk. The inner overflow-hidden does not affect popover rendering, which is governed by the outer DockCard
overflow-visible!. The opencode change is a one-line test inventory sync for an already-merged smoke-title change.How To Verify
Screenshots or Recordings
Screenshot uploaded in Slock thread
#PawWork:fa978555as attachmentd6a37675for visual confirmation.Checklist
dev, and my PR title and commit messages use Conventional Commits in English