fix: remove adapter header#50
Merged
faustbrian merged 9 commits intoArkEcosystemArchive:masterfrom Jan 28, 2019
sleepdefic1t:fix/remove-adapter-header
Merged
fix: remove adapter header#50faustbrian merged 9 commits intoArkEcosystemArchive:masterfrom sleepdefic1t:fix/remove-adapter-header
faustbrian merged 9 commits intoArkEcosystemArchive:masterfrom
sleepdefic1t:fix/remove-adapter-header
Conversation
misc: merge from upstream
The Arduino adapter header does not solve Arduino IDE integration and is otherwise unnecessary. This PR removes the Arduino Adapter header.
Contributor
Author
|
@ciband Failing Linux test looks like it builds platformIO twice for each board. ESP8266 & ESP32 PIO builds are just fine on my system otherwise. Compiling .pioenvs/esp8266/lib75b/src/lib/bip39/make_dictionary/main.cpp.o
/home/circleci/project/src/lib/bip39/make_dictionary/main.cpp:9:22: fatal error: filesystem: No such file or directory
#include <filesystem>
^
compilation terminated.
*** [.pioenvs/esp8266/lib75b/src/lib/bip39/make_dictionary/main.cpp.o] Error 1
========================== [ERROR] Took 25.78 seconds ==========================Compiling .pioenvs/esp32/lib75b/src/lib/bip39/make_dictionary/main.cpp.o
/home/circleci/project/src/lib/bip39/make_dictionary/main.cpp:9:22: fatal error: filesystem: No such file or directory
compilation terminated.
*** [.pioenvs/esp32/lib75b/src/lib/bip39/make_dictionary/main.cpp.o] Error 1
========================== [ERROR] Took 27.17 seconds ========================== |
Contributor
|
CI isn't pulling the latest BIP39 from the library manager (1.0.1 vs 1.1). Looking into it. |
Contributor
|
Further review. PIO isn't ignoring the ./src/lib directory like it should and is compiling in the desktop submodule for BIP39. Not sure why it isn't respecting the -<src/lib> setting. |
Contributor
|
#52 should fix this now. |
Contributor
Author
|
#52 should resolve failing linux build. |
faustbrian
approved these changes
Jan 28, 2019
ciband
pushed a commit
to ciband/cpp-crypto
that referenced
this pull request
Feb 18, 2019
The Arduino adapter header does not solve Arduino IDE integration and is otherwise unnecessary. This PR removes the Arduino Adapter header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The Arduino adapter header
src/arkCrypto.hdoes not solve Arduino IDE integration and is never used in any builds.This PR removes the unnecessary Arduino Adapter header.
Types of changes
Checklist