fix: Correct PIO builds#52
Merged
faustbrian merged 4 commits intoArkEcosystemArchive:masterfrom Jan 28, 2019
Merged
Conversation
Allow individual projects to install dependencies.
PIO was getting the automated dependency checking wrong. Turn it off in favor of being explicit
sleepdefic1t
approved these changes
Jan 27, 2019
Contributor
faustbrian
approved these changes
Jan 28, 2019
ciband
added a commit
to ciband/cpp-crypto
that referenced
this pull request
Feb 18, 2019
* chore: Update bip39 submodule to tips * fix: Remove explicit install of dependencies Allow individual projects to install dependencies. * fix: Add explicit version requirement for BIP39 * fix: Disable dependency checking in PIO PIO was getting the automated dependency checking wrong. Turn it off in favor of being explicit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updated BIP39 submodule and PIO configs to be more explicit in determining dependencies. This allows for more control and better determinism as to what PIO will actually compile into the project.
Types of changes
Checklist
Further comments
This should fix the current build issues in the open PRs.