#3946 remove old engine from query language list#3947
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Coverage variation | ✅ -7.85% coverage variation |
| Diff coverage | ✅ ∅ diff coverage |
Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (bae159c) 117464 86547 73.68% Head commit (338d178) 148703 (+31239) 97889 (+11342) 65.83% (-7.85%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>
Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3947) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes. Give us feedback
There was a problem hiding this comment.
Code Review
This pull request removes the 'Cypher (Old Engine)' option from the query language selection menu. While the UI change is correct, the cleanup is incomplete as dead code remains in the JavaScript logic, and the removal may negatively impact the user experience when loading historical queries that still reference the 'cypher' identifier.
| <option value="sqlScript">SQL Script</option> | ||
| <option value="opencypher">Open Cypher (New Native Engine)</option> | ||
| <option value="gremlin">Gremlin</option> | ||
| <option value="cypher">Cypher (Old Engine)</option> |
There was a problem hiding this comment.
Removing the 'Cypher (Old Engine)' option is correct as per the PR description, but the cleanup appears incomplete. The getEditorMode() function (line 522) still contains logic for the "cypher" language, which is now unreachable from the UI and becomes dead code. Furthermore, this removal may affect the user experience for queries loaded from history: if a saved query has the "cypher" language, the select element will fail to match the value, causing the editor to default to SQL highlighting. Consider mapping "cypher" to "opencypher" in the history loading logic or removing the dead code in the JavaScript.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3947 +/- ##
==========================================
+ Coverage 64.80% 65.21% +0.40%
==========================================
Files 1582 1582
Lines 117464 117464
Branches 24962 24962
==========================================
+ Hits 76128 76600 +472
+ Misses 30947 30406 -541
- Partials 10389 10458 +69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…o [skip ci] Bumps [marked](https://github.com/markedjs/marked) from 18.0.0 to 18.0.2. Release notes *Sourced from [marked's releases](https://github.com/markedjs/marked/releases).* > v18.0.2 > ------- > > [18.0.2](markedjs/marked@v18.0.1...v18.0.2) (2026-04-18) > ----------------------------------------------------------------------------------- > > ### Bug Fixes > > * fix infinite loop for indented code blank line ([ArcadeData#3947](https://redirect.github.com/markedjs/marked/issues/3947)) ([58a52e8](markedjs/marked@58a52e8)) > > v18.0.1 > ------- > > [18.0.1](markedjs/marked@v18.0.0...v18.0.1) (2026-04-17) > ----------------------------------------------------------------------------------- > > ### Bug Fixes > > * **rules:** ensure lookbehind regex is evaluated correctly by minifiers ([ArcadeData#3945](https://redirect.github.com/markedjs/marked/issues/3945)) ([abd907a](markedjs/marked@abd907a)) Commits * [`c4f4529`](markedjs/marked@c4f4529) chore(release): 18.0.2 [skip ci] * [`58a52e8`](markedjs/marked@58a52e8) fix: fix infinite loop for indented code blank line ([ArcadeData#3947](https://redirect.github.com/markedjs/marked/issues/3947)) * [`98b3824`](markedjs/marked@98b3824) chore(release): 18.0.1 [skip ci] * [`abd907a`](markedjs/marked@abd907a) fix(rules): ensure lookbehind regex is evaluated correctly by minifiers ([ArcadeData#3945](https://redirect.github.com/markedjs/marked/issues/3945)) * [`96351c4`](markedjs/marked@96351c4) chore(deps-dev): bump marked-highlight from 2.2.3 to 2.2.4 ([ArcadeData#3946](https://redirect.github.com/markedjs/marked/issues/3946)) * [`c132699`](markedjs/marked@c132699) chore: update testutils ([ArcadeData#3942](https://redirect.github.com/markedjs/marked/issues/3942)) * See full diff in [compare view](markedjs/marked@v18.0.0...v18.0.2) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
What does this PR do?
remove old engine from query language list