fix: tolerate golden error property orders#8126
Merged
Conversation
Contributor
|
|
15e550a to
9f69167
Compare
9f69167 to
eff597d
Compare
michaelfig
reviewed
Aug 1, 2023
Member
michaelfig
left a comment
There was a problem hiding this comment.
Not sure why CI is failing. Can you get it to green?
Member
Author
Still trying. |
dckc
reviewed
Aug 1, 2023
packages/inter-protocol/test/smartWallet/test-psm-integration.js
Outdated
Show resolved
Hide resolved
40d1ff5 to
ae6682d
Compare
ae6682d to
7a32cad
Compare
mhofman
pushed a commit
that referenced
this pull request
Aug 7, 2023
…-order fix: tolerate golden error property orders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
endojs/endo#1678 is now merged into endo. It ensures the property order seen in error message is in sorted order. That fix breaks goldens using non-sorted orders, which are inherently fragile anyway. But agoric-sdk currently depends on an endo prior to endojs/endo#1678 .
Specifically for those tests that would be broken by endojs/endo#1678 , this PR changes them to be tolerant of being in sorted order or not.
#8055 is just like this PR but tested against "current" endo master. If both are green under CI, then this PR should prepare agoric-sdk for that upgrade without breaking it in the meantime.