DO NOT MERGE: test #8126 against "current" endo master.#8055
Closed
DO NOT MERGE: test #8126 against "current" endo master.#8055
Conversation
2035677 to
667d672
Compare
dckc
reviewed
Jul 17, 2023
Member
dckc
left a comment
There was a problem hiding this comment.
Deployment for this looks non-trivial and I don't understand the product motivation, so I'm abstaining from approval.
Since updates to the zoe and smartwallet packages are likely to be deployed separately, I wonder about separating this in to 2 PRs.
It seems like there's a breaking change around here somewhere that I don't see... endo 1678 notes that it's a breaking change, but I don't see a change in agoric-sdk to incorporate endo 1678.
20556bc to
d31700e
Compare
b2b4f4a to
5839b0a
Compare
Member
Author
|
See #8126 |
15e550a to
9f69167
Compare
Contributor
|
|
cf39b2a to
75235df
Compare
9f69167 to
eff597d
Compare
75235df to
5099403
Compare
40d1ff5 to
ae6682d
Compare
5099403 to
d174705
Compare
ae6682d to
7a32cad
Compare
Base automatically changed from
markm-tolerate-golden-error-prop-order
to
master
August 2, 2023 02:07
Member
Author
|
Now that #8126 is merged, this PR is no longer needed. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#endo-branch: mfig-bundle-source-types
This PR is identical to #8126 except for the directive in the PR comment above, to test it against "current" endo master. (Actually, right now it tests against endo mfig-bundle-source-types which fixes an additional problem.)
If both are green under CI, then #8126 should prepare agoric-sdk to be green both before and after this transition.