Merged
Conversation
ahcorde
reviewed
Feb 20, 2019
| double getAverageSegmentDuration() const; | ||
|
|
||
| void getRobotTrajectoryMsg(moveit_msgs::msg::RobotTrajectory& trajectory) const; | ||
| void getRobotTrajectoryMsg(moveit_msgs::msg::RobotTrajectory& trajectory, rclcpp::Clock clock_ros_) const; |
There was a problem hiding this comment.
if you are creating a attribute clock_ros_ you don't need to pass it as an argument
Author
There was a problem hiding this comment.
I was having this error:
error: passing ‘const rclcpp::Clock’ as ‘this’ argument discards qualifiers [-fpermissive]
builtin_interfaces::msg::Time stamp = clock_ros_.now();
ahcorde
approved these changes
Feb 20, 2019
ahcorde
pushed a commit
that referenced
this pull request
Feb 22, 2019
Consolidate logging within moveit_core by creating a dedicated submodule that integrates prior ROS macros
vmayoral
added a commit
that referenced
this pull request
Jun 12, 2019
Using ASan the following memory leak was detected:
#0 0x7f9a7e0b7458 in operator new(unsigned long)
(/usr/lib/x86_64-linux-gnu/libasan.so.4+0xe0458)
#1 0x7f9a7d3480fd in shapes::constructShapeFromText(std::istream&)
/opt/ros2_moveit2_ws/src/geometric_shapes/src/shape_operations.cpp:505
#2 0x7f9a7dc7d561 in planning_scene::PlanningScene::
loadGeometryFromStream(std::istream&, Eigen::Transform<double, 3, 1, 0>
const&) /opt/ros2_moveit2_ws/src/moveit2/moveit_core/planning_scene/
src/planning_scene.cpp:1077
#3 0x7f9a7dc7c336 in planning_scene::PlanningScene::
loadGeometryFromStream(std::istream&) /opt/ros2_moveit2_ws/src/
moveit2/moveit_core/planning_scene/src/planning_scene.cpp:1043
...
The changes proposed here release the shapes::Shape instance
allocated and prevent the memory leak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.