Skip to content

Add Characteristic_Guidance_Web_UI.json#253

Merged
w-e-w merged 2 commits intoAUTOMATIC1111:extensionsfrom
scraed:extensions
Jan 4, 2024
Merged

Add Characteristic_Guidance_Web_UI.json#253
w-e-w merged 2 commits intoAUTOMATIC1111:extensionsfrom
scraed:extensions

Conversation

@scraed
Copy link
Copy Markdown
Contributor

@scraed scraed commented Dec 28, 2023 •
edited
Loading

Characteristic_Guidance_Web_UI

New guidance method providing large CFG scale correction for classifier-free guidance. Compatible with existing sampling methods.

Info

Checklist:

  • I have read the Readme.md
  • The description is written in English.
  • The index.json and extension_template.json have not been modified.
  • The entry is placed in the extensions directory with the .json file extension.

@scraed
Add Characteristic_Guidance_Web_UI.json
edc5434 
new extension: Characteristic_Guidance_Web_UI
@w-e-w w-e-w mentioned this pull request Jan 3, 2024
Merged
@w-e-w
Copy link
Copy Markdown
Collaborator

w-e-w commented Jan 3, 2024 •
edited
Loading

hi sorry took awhile for me to start merging extension to index

I have tested your extension and it does work so it can be added
but there are some issues that I will prefer that you sorted out before it gets merged I've sent over a PR with explanations
scraed/CharacteristicGuidanceWebUI#1

basically if you merge my PR that you should be solved
but please check my PR aligns with your ideals and verify the functionality does work before you merge it

@w-e-w w-e-w self-assigned this Jan 3, 2024
@w-e-w
Copy link
Copy Markdown
Collaborator

w-e-w commented Jan 3, 2024

I remove tab extras tag and added science
seems more fitting
see https://github.com/AUTOMATIC1111/stable-diffusion-webui-extensions/blob/extensions/tags.json

@w-e-w w-e-w mentioned this pull request Jan 3, 2024
Merged
4 tasks
@w-e-w
Copy link
Copy Markdown
Collaborator

w-e-w commented Jan 4, 2024 •
edited
Loading

@scraed
nice I see you have made some changes the keys names used
scraed/CharacteristicGuidanceWebUI@3188027

are the key names final
I want to confirm because it's better that you finalize them before I merge this into index

@scraed
Copy link
Copy Markdown
Contributor Author

scraed commented Jan 4, 2024

@w-e-w Yes, I have merged the PR to fix the infotext issue with some name changes. I think they are final. Thanks again for your PR!

@w-e-w w-e-w merged commit 18271ed into AUTOMATIC1111:extensions Jan 4, 2024
@w-e-w
Copy link
Copy Markdown
Collaborator

w-e-w commented Jan 4, 2024

great

github-actions bot pushed a commit that referenced this pull request Jan 4, 2024
@w-e-w @github-actions
Add Characteristic_Guidance_Web_UI.json (#253)
a6fda57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@w-e-w w-e-w

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scraed @w-e-w