Merged
Conversation
format CHG info text as a json string dict with with double quotes replaced with single simple quotes add infotext_fields for reading the information back using the UI
otherwise if the value int when reading info text the value will be vast to int
This was referenced Jan 3, 2024
Owner
|
@w-e-w Thank you so much for your contribution! The addition of infotext support is fantastic. I hadn't noticed the issue with the UI's inability to read infotext until you pointed it out. Also, the compacted naming options are a great touch, though a few of them could be more precise. I plan to refine these in a future commit. Besides, that is very nice of you to clean up the code. I will merge this PR to the main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compact the infotext from this
to this
I chose the key names based on what makes sense to me, but as I'm not familiar with the code some of the name choices may not be appropriate, it's possible that you can compact it even more
Implement integration so that the infotext can be read by the UI
2024-01-04.00_54_00_832.chrome.mp4
video description:
here are demonstrated that I first set the extension sliders to arbitrary values
then I loaded in a info text from image I generate before then click
read generation parametersbuttonyou can see that the extension sliders are set to the values specified by the infotext
important
becaues you originally set the value of certain elements as int and not float
thise values are save to
ui-config.jsonthe values will also be cast to int when castingpassed from infotext
you will have to delete
ui-config.jsonand let webui regenerate it for this reading info text to work(you could also delete the corresponding keys in
ui-config.json)see set default values to be float
I consider this a bug of web UI and would make a PR to fix this that's for now this is what you have to do
this also means that anyone who has already installed this extension has to also delete
ui-config.jsonto workI made a PR to webui to fix this AUTOMATIC1111/stable-diffusion-webui#14523 but still the issue still stands for webui <= 1.7
I think I have to mention here that I'm also maintainer of AUTOMATIC1111/stable-diffusion-webui-extensions#253
because of the issue of users that I already installed needing deleting of the existing config file to work
I would prefer that you merge this PR before it gets put on the index
note your extension is working so it can be added to the indexed
I don't want to make it seems that I'm using my position as leverage for you to merge my PR this just to avoid issues down the road
other cahnge
you should not have
install.pyin the extension undust you are actually actively using itI removed it remove unused install.py
your file uses you're using a mix of different indentation making the script making it hard to work with so I took the liberty of reformatting the file reformat the entire file make it readable
I also remove the unused Imports remove unused Imports