Add support for signet genesis block#61
Conversation
t-bast
left a comment
There was a problem hiding this comment.
LGTM, just wondering what the Segnet one we have is supposed to be...
| ) | ||
|
|
||
| @JvmField | ||
| public val SignetGenesisBlock: Block = LivenetGenesisBlock.copy( |
There was a problem hiding this comment.
Do you know what the Segnet one above refers to?
There was a problem hiding this comment.
Segnet was a test network that was used to test segwit in 2016. It's most likely dead by now.
There was a problem hiding this comment.
Interesting, I guess we can remove it in this PR then? It's a bit confusing with Signet...
There was a problem hiding this comment.
Agreed, it was ported from bitcoin-lib but is useless now.
|
@remyers can you remove the |
It looks like I will have to recreate on |
Good point, but I think most of these tests are obsolete, and were only useful before segwit was activated. You can probably greatly simplify this test file by just verifying that p2wpkh and p2wsh work as expected, without referencing segnet transactions, this will remove some technical debt! |
|
The tests seemed useful, so I just ported them to testnet in 2581f47 after removing segnet. |
See issue #60 and Eclair discussion/request #2382
This PR also adds check of the final genesis block hashes.