Expose signet support added to bitcoin-kmp#70
Merged
sstone merged 4 commits intoACINQ:masterfrom Aug 18, 2022
Merged
Conversation
Contributor
Author
|
Pending update to version of bitcoin-kmp that adds signet support. |
Contributor
Author
|
@sstone this PR is pending an update of pom.xml to reference the 0.8.5-SNAPSHOT of bitcoin-kmp; I'm not sure what the workflow is for making that happen. |
Member
|
I'll release and publish bitcoin-kmp 0.8.5 today, you can then update the |
t-bast
reviewed
Aug 18, 2022
| assert(tx2.txid == ByteVector32(hex"3acf933cd1dbffbb81bb5c6fab816fdebf85875a3b77754a28f00d717f450e1e")) | ||
| // this tx was published on segnet as 3acf933cd1dbffbb81bb5c6fab816fdebf85875a3b77754a28f00d717f450e1e | ||
| assert(tx2.txid == ByteVector32(hex"f25b3fecc9652466926237d96e4bc7ee2c984051fe48e61417aba218af5570c3")) | ||
| // this tx was published on segnet as f25b3fecc9652466926237d96e4bc7ee2c984051fe48e61417aba218af5570c3 |
Member
There was a problem hiding this comment.
nit: some comments still mention segnet
Contributor
Author
There was a problem hiding this comment.
doh! good catch, I also updated the examples in README.md to use the corresponding values that I changed in the unit tests. fixed in af5c571.
sstone
approved these changes
Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes signet Block hash and blockId from bitcoin-kmp; requires the next version of bitcoin-kmp that includes PR #61.