Fix remember size and position regression in which vertical size could grow when reopening the VM #6239
Conversation
Change window resizing logic when using 4:3 aspect ratio to resize content only. Fixed issues in Remember size and position that are derived from the change. There is a slight flicker while resizing with force 4:3 aspect ratio.
…sbar and remembering size and po The recent rework on the force aspect 4:3 which needed to revisit the remembering of size and position introduced a regression that would save the size without considering the non-content window elements that could be showed or hidden. Now it calculates it accordingly.
|
And there's another regression, in high DPI modes with high DPI scaling, this happens: When turning DPI scaling off and on again, this happens: |
|
Weird, I could swear I tried that setting -in fact I had it marked. But I have a repro. Fix coming shortly. If you can think of any other settings that could be affected apart from the ones considered so far let me know -to ensure there are no more regressions still present from the original fix. |
|
I don't get this. I reproed this. I have been trying for hours to fix this trying all kinds of things in code. Even switched back to earlier versions and try to remake it cleaner. After failing and coming back completely clean to latest and rebuilding from scratch... everything works as intended and I cannot repro this... I even created a new machine in case I added something to my config files... and nothing. I cannot repro it anymore with latest version recompiled clean. This might take a bit longer as I am quite puzzled right now. |
|
No, I don't get it. Neither with the latest development build. @OBattler -or someone else, could you please try to reproduce this with the latest development build? Maybe we have seen some strange artifact due to a code upgrade that somehow goes away with a clean rebuild? |
…ize could grow when reopening the VM (86Box#6239)" This reverts commit 74aa156.
…viour (#6264) * Revert "Fix remember size and position regression in which vertical size could grow when reopening the VM (#6239)" This reverts commit 74aa156. * Revert "Change window resizing logic when using 4:3 aspect ratio (#6233)" This reverts commit bc085ac. * Revert "Run more iterations and retested" This reverts commit ca429dd. * Revert "Fix Force 4:3 Aspect Ratio not working if Resizable window is enabled #6062" This reverts commit 717b66c. * Implement Force 4:3 option for resizable windows with fullscreen behaviour
Summary
Fixes the regression introduced in #6233 in which the vertical size could keep growing on VM reopen when remembering size and pos, due to not removing from the height the showed or hidden non-content elements (toolbar and status bar).
This fix ensures they are taken into account for the vertical size.
Tested with multiple combinations of parameters while reopening the machine, this time taking into account only the size of the content area. Of course including Hide Toolbar, Hide Status Bar and combinations of those while reopening the VM and ensuring the size remains.
Unfortunately it is extremely hard to ensure that this functionality works correctly in all cases as there are too many parameters that interact with each other sometimes even in contradicting ways. That said, I can just offer to jump in whenever anything is found related to any of my changes to fix it to the best of my ability.
Checklist
References
(#6233)
https://discord.com/channels/262614059009048590/1421479562029830154