Change window resizing logic when using 4:3 aspect ratio #6233
Conversation
Change window resizing logic when using 4:3 aspect ratio to resize content only. Fixed issues in Remember size and position that are derived from the change. There is a slight flicker while resizing with force 4:3 aspect ratio.
|
I know it's not 100% relevant to this PR but just to point out, as I already did with one of the developers in a discussion I opened, that the current 4:3 scaling is far from ideal for several reasons. |
|
This has introduced the following regression, reposting from the Discord server: There is no error in build 7865. In build 7866, if the "Specify main window dimensions - Lock to this size" option is disabled, if "Hide toolbar" and "Hide status bar" are disabled, and if the "Force 4:3 display ratio" option is enabled, then the window coordinates are not saved (the last number is reset in the window_coordinates line) in the 86Box.cfg file when the machine starts: to Each time the machine starts, black horizontal frames will appear and grow larger at the top and bottom of the window, and the window itself will shift to the bottom of the screen. This will reset the window coordinates in the 86Box.cfg file: |
Damn... On it. |
…viour (#6264) * Revert "Fix remember size and position regression in which vertical size could grow when reopening the VM (#6239)" This reverts commit 74aa156. * Revert "Change window resizing logic when using 4:3 aspect ratio (#6233)" This reverts commit bc085ac. * Revert "Run more iterations and retested" This reverts commit ca429dd. * Revert "Fix Force 4:3 Aspect Ratio not working if Resizable window is enabled #6062" This reverts commit 717b66c. * Implement Force 4:3 option for resizable windows with fullscreen behaviour
Summary
With the current 4:3 resizing logic, maximizing the window would maximize horizontally and leave part of the window outside the screen. It seems to be desired that the resizing happens in the content -like PCEm- and not the window. See new comment in previous PR #6062 (comment) requesting the change.
The previous approach could also become glitchy, especially when trying to reduce the window size, which is solved by this new approach.
Therefore, this PR changes window resizing logic when using 4:3 aspect ratio to resize content only instead of resizing the window. Also fixed issues in Remember size and position that are derived from the change.
Known issues:
Tested
In Windows with multiple combinations of
Checklist
References
Provide links to datasheets or other documentation that helped you implement this pull request.