Commit files that were built outside of the action#130
Merged
Conversation
1 task
iamdharmesh
approved these changes
Aug 21, 2023
iamdharmesh
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR @akirk and Apologies for the delayed review. LGTM!
This was referenced Sep 7, 2023
dkotter
added a commit
to 10up/action-wordpress-plugin-build-zip
that referenced
this pull request
Sep 11, 2024
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
When you don't have a BUILD_DIR and a .distignore file, any changes inside the git directory will be ignored when committing to SVN.
This is because we use
git archive HEADwhich builds the archive from the git index, not the directory tree.A workaround is to manually commit the files in the build step, see GlotPress/GlotPress#1655
Equally well, we can just commit any file changes inside the deploy script since the git changes are only local.
How to test the Change
.distignorefile.→ The built or modified files should be included in the svn release.
Changelog Entry
Credits
Props @akirk
Checklist:
(I'll update the checklist as soon as the build checks have run)