Fix including the minified assets in the WP.org deploy#1655
Merged
Conversation
Member
|
I would like to understand why it's not working as expected according the https://github.com/10up/action-wordpress-plugin-deploy docs. |
Member
Author
|
Yes, the build works but then the built files are not included in SVN: |
4 tasks
Member
|
Will adding the .distignore file solve it? |
Member
Author
|
It would but why not just re-use the |
Member
|
Great that you've identified the bug upstream! :) |
trymebytes
approved these changes
Jul 13, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The approach in #1654 doesn't include the built minified assets even though the example readme in https://github.com/10up/action-wordpress-plugin-deploy suggests otherwise.
It turns out that the action uses
git archiveif you don't have a.distignore. If we build the files into the git monitored directory, then those newly built files are ignored bygit archivesince it creates the archive from its index files.Relates to #1587.
Solution
git committhe newly built files.Tasks