Skip to content

SimulateTransactions integration tests#628

Merged
marioiordanov merged 16 commits intomainfrom
simulation_tests
Oct 22, 2024
Merged

SimulateTransactions integration tests#628
marioiordanov merged 16 commits intomainfrom
simulation_tests

Conversation

@marioiordanov
Copy link
Copy Markdown
Contributor

@marioiordanov marioiordanov commented Oct 17, 2024

Development related changes

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
    • Once you make the PR reviewable, please avoid force-pushing
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@marioiordanov marioiordanov linked an issue Oct 17, 2024 that may be closed by this pull request
@marioiordanov marioiordanov marked this pull request as ready for review October 17, 2024 19:53
@FabijanC FabijanC mentioned this pull request Oct 21, 2024
10 tasks
@marioiordanov marioiordanov merged commit 79e288c into main Oct 22, 2024
@marioiordanov marioiordanov deleted the simulation_tests branch October 22, 2024 08:46
marioiordanov added a commit that referenced this pull request Oct 25, 2024
* SimulateTransactions integration tests (#628)

* remove handle_transaction_result, refactor errors

* integration tests

* added new error type

* typo

* fixed unit tests

* fixed integration test

* remove fully qualified names in errors file

* changed test name

* reuse variable

* replace declare_deploy_v1 with declare_v3_deploy_v3

* add simulate transaction validation check

* add functionality

* refactor if else with match 

* remove trait implementation

* changed error variant

* commment

* resolve compilation errors

* fix integration tests

* clippy

* removed let [skip ci]

* removed duplicated method [skip ci]

* remove duplicated test [skip ci]

* clippy

* clippy [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve testing of starknet_simulateTransactions

2 participants