Skip to content

Improve testing of starknet_simulateTransactions #192

@FabijanC

Description

@FabijanC

Tests in crates/starknet-devnet/tests/test_simulate_transactions.rs were written to have the same coverage as devnet-py the corresponding devnet-py tests. Currently there are TODOs:

  • Better testing of SKIP_FEE_CHARGE by using a greater than zero max_fee in several tests
  • Add testing of invoke tx simulation being reverted (could be done by using an invalid max_fee (checked: this leads to a Reverted case that is currently not tested))
    - Another test needs replacement of .ge with .gt (basically we would want to assert that using SKIP_VALIDATE actually lowers the estimated fee, but currently it does not have effect, as described in this issue: SKIP_VALIDATE not affecting fee in simulation lambdaclass/starknet_in_rust#1051)
    • This issue can be addressed separately as it would not merely be enhancement but fix
  • Use starknet.rs's .simulate(...) instead of manually constructing simulation requests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    MediumTask is of medium difficulty to fixenhancementNew feature or requesttestingRelated to code testing

    Type

    No type

    Projects

    Status

    ✅ Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions