-
Notifications
You must be signed in to change notification settings - Fork 77
Improve testing of starknet_simulateTransactions #192
Copy link
Copy link
Closed
Labels
MediumTask is of medium difficulty to fixTask is of medium difficulty to fixenhancementNew feature or requestNew feature or requesttestingRelated to code testingRelated to code testing
Description
Tests in crates/starknet-devnet/tests/test_simulate_transactions.rs were written to have the same coverage as devnet-py the corresponding devnet-py tests. Currently there are TODOs:
- Better testing of SKIP_FEE_CHARGE by using a greater than zero max_fee in several tests
- Add testing of invoke tx simulation being reverted (could be done by using an invalid max_fee (checked: this leads to a Reverted case that is currently not tested))
- Another test needs replacement of .ge with .gt (basically we would want to assert that using SKIP_VALIDATE actually lowers the estimated fee, but currently it does not have effect, as described in this issue: SKIP_VALIDATE not affecting fee in simulation lambdaclass/starknet_in_rust#1051)This issue can be addressed separately as it would not merely be enhancement but fix
- Use starknet.rs's
.simulate(...)instead of manually constructing simulation requests.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
MediumTask is of medium difficulty to fixTask is of medium difficulty to fixenhancementNew feature or requestNew feature or requesttestingRelated to code testingRelated to code testing
Type
Projects
Status
✅ Done