Skip to content

Fix generate-keystore command#424

Merged
Raneet10 merged 3 commits intodevelopfrom
raneet10/fix-generate-keystore
Aug 11, 2025
Merged

Fix generate-keystore command#424
Raneet10 merged 3 commits intodevelopfrom
raneet10/fix-generate-keystore

Conversation

@Raneet10
Copy link
Copy Markdown
Contributor

Description

This PR fixes generate-keystore command to respect the private key provided for the keystore. It also adds a --generate-new flag to create a random keystore (which was the behaviour till this PR). If both private key and flag are provided, the former will take precedence.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least two reviewers or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments — if any — by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on the local environment
  • I have tested this code manually on a remote devnet using express-cli
  • I have tested this code manually on amoy/mumbai
  • I have created new e2e tests into express-cli

@sonarqubecloud
Copy link
Copy Markdown

@Raneet10 Raneet10 merged commit fe9529a into develop Aug 11, 2025
11 checks passed
@Raneet10 Raneet10 deleted the raneet10/fix-generate-keystore branch August 11, 2025 12:15
Raneet10 added a commit that referenced this pull request Aug 14, 2025
* cmd: allow generate-keystore to accept private key

* cmd: add --generate-new flag
Raneet10 added a commit that referenced this pull request Aug 14, 2025
* x/bor: add missing span duration check

* Fix generate-keystore command (#424)

* cmd: allow generate-keystore to accept private key

* cmd: add --generate-new flag

* helper: fix lint
marcello33 added a commit that referenced this pull request Sep 2, 2025
* Delete spans backfill

* Always vote NO on spans backfill

* Return type assertion for MsgBackfillSpan

* Merge pull request #413 from 0xPolygon/kamui/bump-kurtosis

chore: remove validator test case and bump kurtosis

* chore: side msg and abci handler metrics (#410)

* chore: add side msg metrics

* timer metrics for Pre, Begin, and End blocker funcs

* chore: nits

* abci handler metrics

* chore: use Namespace from metrics package

* misc: migrated from maticnetwork to 0xPolygon (#420)

* misc: migrated from maticnetwork to 0xPolygon

* misc: bump cosmos to v0.2.3-polygon

* misc: bump bor

* misc: addressed comments

* chore: bump kurtosis (#422)

* chore: bump kurtosis

* chore: add milestones test

* fix: test case name

* chore: update test_runner image

* Re-enable voting power check in tally votes (#409)

* app,helper,x/stake: add logic to store penultimate valset

* app: use correct valset in ValidateVoteExtensions

* app: fix if condition

* app: add condition for genesis

* app,x/chainmanager: track initial chain height for UTs

* app,helper,x/milestone: re-enable skipped validator not found errors

* app: fix some tests and refactor a bit

* app,bridge: fix more tests

* app,x/milestone: some cleanup

* app: dedup redundant stubs

* app: more cleanup

* app,helper,x/chainmanager: move setting of initial height outside of x/chainmanager

* app: improved error logging

* app,x/chainmanager: rm unused key + minor nit

* app: deterministically extract max hash and VP from non-rp VE

* x/stake: fix lint

* helper: refactoring

* app: add comment

* bump go to 1.24.6

* helper: rm unnecessary todo

* fix: build (#423)

* Fix generate-keystore command (#424)

* cmd: allow generate-keystore to accept private key

* cmd: add --generate-new flag

* update: cosmos-sdk (#425)

* helper: fix conflicts

* feat: bump kurtosis and migrate to pos-workflows (#431)

* feat: remove matic-cli e2e-tests (#432)

* bridge: improvements / app: improvements (#427)

* improve bridge, remove bridge cli, minor fixes

* validate bor_chain_id in checkpoints flow

* test fee-transfer events emissions

* remove test block

* logs on rest server being unresponsive

* improve initRootCmd

* don't return on ctx done / restServerTimeOutInMinutes to 1m for tests

* improve logs / restore restServerTimeOutInMinutes

* sort imports

* fix comment

* fix tests and linter issues

* bump cosmos-sdk dep

* move const outside of the func

* refactor StartWithCtx function

* address comments

* log anomaly if account not found with node being in sync

* Set voting power and valset check heights for amoy (#435)

* helper: set tallyFixHeight and disableVPCheckHeight for amoy

* helper: set disableValSetCheckHeight for amoy

* helper: set initialHeight for amoy

* api,proto,x/stake: add penultimate valset to genesis export + add some tests (#436)

* set tallyfix mainnet hf heights

---------

Co-authored-by: Angel Valkov <avalkov@polygon.technology>
Co-authored-by: Krishang Shah <109511742+kamuikatsurgi@users.noreply.github.com>
Co-authored-by: Pratik Patil <pratikspatil024@gmail.com>
Co-authored-by: Raneet Debnath <35629432+Raneet10@users.noreply.github.com>
Co-authored-by: Raneet Debnath <raneetdebnath10@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants