Skip to content

Add span range check#426

Merged
Raneet10 merged 3 commits intomainfrom
raneet10/fix-span-range
Aug 14, 2025
Merged

Add span range check#426
Raneet10 merged 3 commits intomainfrom
raneet10/fix-span-range

Conversation

@Raneet10
Copy link
Copy Markdown
Contributor

Description

This PR adds a check to verify the proposed span length. Also cherry-picks the fix for generate-keystore command.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least two reviewers or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments — if any — by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on the local environment
  • I have tested this code manually on a remote devnet using express-cli
  • I have tested this code manually on amoy/mumbai
  • I have created new e2e tests into express-cli

Raneet10 and others added 2 commits August 12, 2025 21:36
* cmd: allow generate-keystore to accept private key

* cmd: add --generate-new flag
@sonarqubecloud
Copy link
Copy Markdown

@Raneet10 Raneet10 merged commit 1ec3f5f into main Aug 14, 2025
9 of 11 checks passed
@Raneet10 Raneet10 deleted the raneet10/fix-span-range branch August 14, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants