Skip to content

v2.2.10#1715

Merged
pratikspatil024 merged 29 commits intomasterfrom
v2.2.10-candidate
Aug 21, 2025
Merged

v2.2.10#1715
pratikspatil024 merged 29 commits intomasterfrom
v2.2.10-candidate

Conversation

@pratikspatil024
Copy link
Copy Markdown
Member

Description

Please provide a detailed description of what was done in this PR

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

yumeiyin and others added 29 commits July 16, 2025 11:50
… db (#1623)

Pass around a wrapper `vm.StateDB` instance and expose public methods for accessing underlying state db which can be different for normal v/s tracing mode.
…ncase of timeout (#1625)

Interrupt block building in fill transactions if we're above time. We pass around the worker level interrupt atomic value to handle the interrupt in transaction pool's pending function and ordering function in worker.
* Remove v1 v2 hiemdall detection

* Delete hv1/hv2 detection logic and self-committing of spans

* Remove unused functions

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* If fetching state sync fails, just continue with empty state syncs
Use a new config for all tests (some of which run in parallel) instead of using a global test config which can cause race conditions if some fields (like commit interrupt) are modified for some tests.
* feat: use multi-stage build in Dockerfile

* chore: nits

* chore: remove comments

* chore: add bash in runtime image

* chore: use alpine latest
* feat(ci): kurtosis for e2e-tests

* chore: kurtosis migration

* use tag instead of commit
Decouple heap calculations to reduce the waiting time for miner/worker to produce the next block. This tweaks the consistency model of the pool from being strictly consistent to eventually consistent. During internal pool re-arrangements, it prioritises the miner waiting to access the pending pool instead of doing complex time consuming calculations.
Adds some observability to capture delays during block building. 

- Time taken to acquire lock in pending pool
- Time taken for the whole pending call to finish (this matters the most for miner during block building)
- Time taken to release the lock held during tx pool reorg
- Time taken to init a heap out of the pending transactions before starting to execute transactions
- Time taken to actually execute transactions in ideal mining workflow
* chore: bump kurtosis

* chore: update test runner image

* chore: add milestones test

* chore: minor nit
* misc: migrated from maticnetwork to 0xPolygon

* misc: bumped heimdall-v2

* misc: bumped heimdall-v2 and bor

* misc: bumped heimdall-v2, build works now

* misc: updated matic-cli branch

* misc: updated cosmos version
* Key Value Read Priority on BorReceipts

* simplify code
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
7.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@pratikspatil024 pratikspatil024 requested a review from a team August 21, 2025 10:21
@kamuikatsurgi
Copy link
Copy Markdown
Member

The i386 linux tests are not running because they have runs-on: self-hosted. Do we have any self-hosted machines?

@pratikspatil024 pratikspatil024 merged commit 0e508e4 into master Aug 21, 2025
10 of 15 checks passed
@pratikspatil024 pratikspatil024 deleted the v2.2.10-candidate branch August 21, 2025 10:42
@marcello33
Copy link
Copy Markdown
Collaborator

The i386 linux tests are not running because they have runs-on: self-hosted. Do we have any self-hosted machines?

No. Discussed once with Daniel and I disabled them once. We should delete them (not mandatory for this release ofc)

@kamuikatsurgi
Copy link
Copy Markdown
Member

The i386 linux tests are not running because they have runs-on: self-hosted. Do we have any self-hosted machines?

No. Discussed once with Daniel and I disabled them once. We should delete them (not mandatory for this release ofc)

Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants