core/miner: observability for block building delays#1682
Merged
Conversation
cffls
approved these changes
Aug 4, 2025
ssandeep
approved these changes
Aug 5, 2025
kamuikatsurgi
approved these changes
Aug 5, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds observability metrics to track delays during block building in the Ethereum miner. The goal is to provide better insights into where bottlenecks occur during the mining process, particularly around transaction pool operations and transaction execution.
Key changes include:
- Added timing metrics for transaction heap initialization and transaction execution in the worker
- Added timing metrics for lock acquisition and total duration of pending transaction retrieval from the transaction pool
- Added timing metrics for lock duration during transaction pool reorganization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| miner/worker.go | Adds metrics for transaction heap initialization and transaction execution timing |
| core/txpool/legacypool/legacypool.go | Adds metrics for pending call duration, lock wait times, and reorg lock duration |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
nebojsa94
pushed a commit
to nebojsa94/bor
that referenced
this pull request
Aug 14, 2025
Adds some observability to capture delays during block building. - Time taken to acquire lock in pending pool - Time taken for the whole pending call to finish (this matters the most for miner during block building) - Time taken to release the lock held during tx pool reorg - Time taken to init a heap out of the pending transactions before starting to execute transactions - Time taken to actually execute transactions in ideal mining workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds some observability to capture delays during block building. Mainly captures
Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it