core, eth, miner: interrupt block building during fill transactions incase of timeout#1625
Merged
core, eth, miner: interrupt block building during fill transactions incase of timeout#1625
Conversation
cffls
reviewed
Jul 21, 2025
cffls
approved these changes
Jul 21, 2025
kamuikatsurgi
approved these changes
Jul 21, 2025
nebojsa94
pushed a commit
to nebojsa94/bor
that referenced
this pull request
Aug 14, 2025
…ncase of timeout (0xPolygon#1625) Interrupt block building in fill transactions if we're above time. We pass around the worker level interrupt atomic value to handle the interrupt in transaction pool's pending function and ordering function in worker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use commit interrupt for fill transactions as well.
We interrupt executing new transactions when the 2s block time mark is crossed. Although before execution, we call
Pending()function of transaction pool which can be time consuming in some cases. If the 2s time limit is up, we'd like to interrupt that call as well to avoid spending any more time on doing any work for this block.This PR passes the
interruptatomic boolean (which is used across the modules to trigger interrupt) when we're fetching the pending transactions and sorting them based on nonce and fee before executing.Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it