Skip to content

feat: rename miden-objects into miden-protocol and miden-lib into miden-standards#2197

Merged
bobbinth merged 77 commits intonextfrom
pgackst-protocol-and-standards-rename
Dec 20, 2025
Merged

feat: rename miden-objects into miden-protocol and miden-lib into miden-standards#2197
bobbinth merged 77 commits intonextfrom
pgackst-protocol-and-standards-rename

Conversation

@PhilippGackstatter
Copy link
Copy Markdown
Contributor

@PhilippGackstatter PhilippGackstatter commented Dec 18, 2025

Renames miden-objects into miden-protocol and miden-lib into miden-standards, following the previous PR #2191.

Main changes

ProtocolLib

  • The namespace is simply changed from miden to miden::protocol.

StandardsLib

  • Renames crates/miden-lib/asm/miden/ -> crates/miden-standards/asm/standards/.
  • Changes assembly of the StandardsLibrary to use the miden::standards namespace.
  • Deletes the contracts directory.

This results in miden::contracts::faucets mapping to miden::standards::faucets, next to miden::standards::auth and miden::standards::wallets.

Note that account components and note scripts are left untouched. See follow-ups.

miden-objects

Renamed to miden-protocol.

miden-lib

Renamed to miden-standards.

Slot Names

In line with the above, also renames:

  • the slot name miden::faucet::sysdata -> miden::protocol::faucet::sysdata.
  • the slot name miden::network_fungible_faucet::owner_config -> miden::standards::network_fungible_faucet::owner_config.

Review

I tried to keep commits organized and so reviewing by commit might make things easier to follow.

Most commits are relatively small, the two biggest ones are those that update imports.

Follow-Ups

For another PR, we can consider:

  • In general, making library paths, event names and slot names consistent in their namespacing, i.e. either miden::protocol or miden::standards.
    • Slot names should be consistent after this PR, but events need a slight rename, for example:
    • Consider changing library paths of account components to be in the miden::standards namespace, e.g.:
      • basic_fungible_faucet::distribute could become miden::standards::faucets::basic_fungible_faucet::distribute. This needs a little more thought though because this may collide or be inconsistent with the existing miden::standards::faucets::basic_fungible.
  • Check miden-protocol for types that are actually standards, like TokenSymbol and move them to standards.
    • One interesting case is miden_protocol::account::auth::{AuthSecretKey, Signature} which are probably standards.

closes #1563

Fumuran and others added 30 commits December 10, 2025 18:41
Copy link
Copy Markdown
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left just a couple of small comments inline.

Base automatically changed from pgackst-split-protocol-and-standards to next December 20, 2025 08:43
@bobbinth bobbinth merged commit eb0c396 into next Dec 20, 2025
18 checks passed
@bobbinth bobbinth deleted the pgackst-protocol-and-standards-rename branch December 20, 2025 09:34
afa7789 pushed a commit to afa7789/miden-base that referenced this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider rename the repo to miden-protocol

4 participants