feat: rename miden-objects into miden-protocol and miden-lib into miden-standards#2197
Merged
feat: rename miden-objects into miden-protocol and miden-lib into miden-standards#2197
miden-objects into miden-protocol and miden-lib into miden-standards#2197Conversation
…/miden-base into andrew-migrate-to-v20-vm
bobbinth
approved these changes
Dec 18, 2025
Contributor
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left just a couple of small comments inline.
…ocol-and-standards
…ocol-and-standards-rename
Base automatically changed from
pgackst-split-protocol-and-standards
to
next
December 20, 2025 08:43
This was referenced Dec 20, 2025
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Jan 15, 2026
…to `miden-standards` (0xMiden#2197)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
miden-objectsintomiden-protocolandmiden-libintomiden-standards, following the previous PR #2191.Main changes
ProtocolLibmidentomiden::protocol.StandardsLibcrates/miden-lib/asm/miden/->crates/miden-standards/asm/standards/.StandardsLibraryto use themiden::standardsnamespace.contractsdirectory.This results in
miden::contracts::faucetsmapping tomiden::standards::faucets, next tomiden::standards::authandmiden::standards::wallets.Note that account components and note scripts are left untouched. See follow-ups.
miden-objectsRenamed to
miden-protocol.miden-libRenamed to
miden-standards.Slot Names
In line with the above, also renames:
miden::faucet::sysdata->miden::protocol::faucet::sysdata.miden::network_fungible_faucet::owner_config->miden::standards::network_fungible_faucet::owner_config.Review
I tried to keep commits organized and so reviewing by commit might make things easier to follow.
Most commits are relatively small, the two biggest ones are those that update imports.
Follow-Ups
For another PR, we can consider:
miden::protocolormiden::standards.event("miden::tx::prologue_start")->event("miden::protocol::tx::prologue_start")miden::protocol#2198.miden::standardsnamespace, e.g.:basic_fungible_faucet::distributecould becomemiden::standards::faucets::basic_fungible_faucet::distribute. This needs a little more thought though because this may collide or be inconsistent with the existingmiden::standards::faucets::basic_fungible.miden-protocolfor types that are actually standards, likeTokenSymboland move them to standards.miden_protocol::account::auth::{AuthSecretKey, Signature}which are probably standards.closes #1563