Conversation
Fumuran
approved these changes
Oct 22, 2025
Contributor
Fumuran
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you for making this test more clear!
As just one small nit I would add a short description above this test explaining which cases are we checking here (i.e. auth and unauth notes without multisig signatures, auth and unauth notes with multisig signatures) and what result and why do we expect in each case.
Collaborator
Author
|
Thanks for a quick review. Good idea with the description, I added it now in chore: update test description |
partylikeits1983
pushed a commit
that referenced
this pull request
Oct 27, 2025
… in test (#2013) * chore: explicitly try consume both authenticated and unauthenticated note * chore: update test description
mmagician
added a commit
that referenced
this pull request
Oct 29, 2025
* feat: init ntx faucet * chore: update changelog * refactor: address nits & comments * refactor: add comment in burn procedure * feat: BURN & MINT notes * refactor: revert changes and address nits * refactor: cleanup * fix: new mock_chain method fix * refactor: minor comment updates * refactor: use account_id::is_equal * refactor: split faucet/mod.rs into two * fix: fix merge issues & nits * refactor: address nits * refactor: address nits * refactor: use AccountId in ntx faucet contructor * feat: add doc comments & update well_known_note * refactor: address nits * refactor: address pad nits * refactor: address nits * feat: add distribute padding procedure * fix: rustfmt * fix: make tests async * refactor: address nit * fix: fix stack comment * refactor: add padding in distribute * Update crates/miden-lib/asm/miden/contracts/faucets/network_fungible.masm Co-authored-by: Marti <marti@miden.team> * refactor: move burn proc to contracts/faucets/mod.masm * refactor: address MINT note nit * refactor: address basic fungible faucet comment * refactor: set default faucet decimals * Update crates/miden-testing/tests/scripts/faucet.rs Co-authored-by: Marti <marti@miden.team> * refactor: address nits * refactor: address padding stack comment nits * refactor: clarify comment * refactor: address comment nits * feat: consume minted output note from ntx faucet * feat: add test & fix lint warnings * refactor: address stack comments * fix: changelog * fix: minor updates * chore: clean up stack comments in MINT note script * chore: address PR comment regarding test code comment being incorrect * chore: remove debug_assert_eq statement from well_known_note logic * chore: rustfmt * Update crates/miden-testing/tests/scripts/faucet.rs Co-authored-by: Marti <marti@miden.team> * Update crates/miden-testing/tests/scripts/faucet.rs Co-authored-by: Marti <marti@miden.team> * Update crates/miden-testing/tests/scripts/faucet.rs Co-authored-by: Marti <marti@miden.team> * feat: improve network faucet mint / burn tests to show asset balance increase / decrease * Update crates/miden-lib/asm/note_scripts/MINT.masm Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * Update crates/miden-lib/asm/miden/contracts/faucets/network_fungible.masm Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * Update crates/miden-lib/asm/miden/contracts/faucets/network_fungible.masm Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * Update crates/miden-lib/asm/note_scripts/MINT.masm Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * refactor: improve faucet documentation and make BURN note generic * refactor: remove usage of local memory in faucets::distribute * refactor: fix stack comment in MINT note * refactor: fix padding comments in MINT note * Update crates/miden-lib/asm/miden/contracts/faucets/basic_fungible.masm Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * Update crates/miden-testing/tests/scripts/faucet.rs Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * chore: explicitly consume both authenticated and unauthenticated note in test (#2013) * chore: explicitly try consume both authenticated and unauthenticated note * chore: update test description * feat: re-export Section and SectionId (#2015) * chore: migrate docs from mdbook to docusaurus - Migrated documentation from mdbook to docusaurus - Updated protocol_library.md with detailed formatting and resolved merge conflicts - Added proper markdown links and structure - Incorporated new procedures from next branch - Added build and deployment workflows for docs * chore(Makefile): add serve-docs command and implement checking for NPM dependency * docs(README): add section explaining external documentation * chore(docs): convert .json docusaurus category files to yml format * fix(docs): fix broken links * chore: use specific ref for trigger-deploy-docs.yml workflow * docs: implement custom styling * Update crates/miden-lib/src/account/interface/mod.rs Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * refactor: truncate stack explicitly in MINT note before call * fix: fix comment to reference correct faucet metadata slot index * refactor: update to use procedure_digest! macro for faucets * Update crates/miden-lib/src/account/faucets/network_fungible.rs Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * Update crates/miden-lib/src/account/faucets/network_fungible.rs Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * refactor: use BasicFungibleFaucet inside NetworkFungibleFaucet to reduce duplication * fix: update to use fully qualified path of FungibleAsset::MAX_AMOUNT for ntx faucet doc comment * refactor: store owner_account_id as AccountId in NetworkFungibleFaucet * refactor: add padding to stack comments in /facuets/mod.masm * refactor: revert send_note test to use NoteType::Public * refactor: simplify create_network_fungible_faucet signature --------- Co-authored-by: Bobbin Threadbare <43513081+bobbinth@users.noreply.github.com> Co-authored-by: Marti <marti@miden.team> Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> Co-authored-by: Tomas Fabrizio Orsi <tomas.orsi@lambdaclass.com> Co-authored-by: keinberger <philipp.keinberger@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No change in consumability checker functionality.
This PR simply makes the test more explicit so that it's clear how providing authenticated vs. unauthenticated notes to the consumption checker should behave for a multisig.
closes #1936